[OSJC 61-66-71] fixing where timeouts are read from #127
Conversation
|
[test] |
|
Java Client Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test-openshift-java-client/19/) |
| @@ -31,6 +31,7 @@ | |||
| protected static final String KEY_RHLOGIN = "default_rhlogin"; | |||
| protected static final String KEY_LIBRA_SERVER = "libra_server"; | |||
| protected static final String KEY_LIBRA_DOMAIN = "libra_domain"; | |||
| protected static final String OPENSHIFT_TIMEOUT = "express.timeout"; | |||
There was a problem hiding this comment.
I'd also stick to the naming scheme used for the other constants "KEY_OPENSHIFT_TIMEOUT"
I'd also stick to "timeout" instead of "express.timeout" to match the keys in the express.conf:
The default timeout for network operations
timeout=
and make sure we're using "express.timeout" in the system properties only (since we want to make sure we're not override by some other program in the same jvm that's possibly using "timeout").
|
looks perfect, thanks! |
|
Java Client Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge-openshift-java-client/174/) |
|
Evaluated for javaclient up to 4e57326 |
Merged by openshift-bot
Updated to have a default timeout of 3 minutes, which can be overridden by the system configuration (/etc/openshift/express.conf), which can be overridden by the user configuration (~/.openshift/express.conf), which can be overridden by system properties (-Dexpress.timeout=). Also wrote associated tests to test overriding, and added a couple of more "fakes" that were needed for the tests.