Modified scope definitions and changed to use "expires_in_seconds" #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skavanagh
changed the title
skavanagh
force-pushed
the
expires-scopes-branch
branch
from
c557849
to
944e585
Compare
Defined session, read, and userinfo scopes. Added unit test to check scope permissions and expired token
Modified to use 'expires_in_seconds' which returns the remaining time for the authorization.
skavanagh
force-pushed
the
expires-scopes-branch
branch
from
944e585
to
513d25e
Compare
|
Great, thanks! rebasing and merging... |
|
nice patch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
http://openshift.github.io/documentation/rest_api/rest-api-1-6.html#authorization
The default scopes are
session - Equivalent of logging into an account with normal login credentials such as user name and password.
read - Access to the API is read-only, while authorization endpoints cannot be read.
userinfo - Only read access to the /user API resource is provided.
I know I confused things by having "sesson read" (which I think just means "session") in one of my unit tests. I was just trying to see if they could be combined. I added the scopes and a couple of unit tests to check permissions.
Also, "expires_in" returns the expiration time that was originally set for the authorization. "expires_in_seconds" returns the time remaining. So I think we would want that one.
Thanks!