Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBIDE-15666] Missing SSH_URL and Cartridges properties when reading Gea... #90

Merged
merged 1 commit into from Oct 16, 2013
Merged

[JBIDE-15666] Missing SSH_URL and Cartridges properties when reading Gea... #90

merged 1 commit into from Oct 16, 2013

Conversation

adietish
Copy link
Member

...r(s) in GearGroups

Added both properties
The cartridges returned by the IGearGroup#getCartridges() method are the one that
already exist in the parent IApplication. No need to create another subclass
of BaseCartridge, and the returned collection contains both IStandaloneCartridge(s)
and IEmbeddedCartridge(s)
The GearGroups collection is always refreshed because it is not cached in the ApplicationResource

Added unit tests to cover the parsing

@xcoulon
[JBIDE-15666] Missing SSH_URL and Cartridges properties when reading …
6158bb6 
…Gear(s) in GearGroups

Added both properties
The cartridges returned by the IGearGroup#getCartridges() method are the one that
already exist in the parent IApplication. No need to create another subclass
of BaseCartridge, and the returned collection contains both IStandaloneCartridge(s)
and IEmbeddedCartridge(s)
The GearGroups collection is always refreshed because it is not cached in the ApplicationResource

Added unit tests to cover the parsing
@adietish
Copy link
Member Author

[merge]

@openshift-bot
Copy link

Java Client Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge-openshift-java-client/129/)

@adietish
Copy link
Member Author

again the tests failed because of connection problems:

Tests in error:
shouldEmbedMongo(com.openshift.internal.client.EmbeddedCartridgeResourceIntegrationTest): Could not request https://ec2-54-226-104-194.compute-1.amazonaws.com/broker/rest/domain/1381947364799/application/1381948325943/cartridges: exception: connect failed(..)
shouldHaveUrlInEmbeddedMongo(com.openshift.internal.client.EmbeddedCartridgeResourceIntegrationTest): Could not request https://ec2-54-226-104-194.compute-1.amazonaws.com/broker/rest/domain/1381947364799/application/1381948325943/cartridges: exception: connect failed(..)
shouldHaveUrlInEmbeddedRockMongo(com.openshift.internal.client.EmbeddedCartridgeResourceIntegrationTest): Could not request https://ec2-54-226-104-194.compute-1.amazonaws.com/broker/rest/domain/1381947364799/application/1381948515516/cartridges: exception: connect failed(..)

...respinning.

@adietish
Copy link
Member Author

[merge]

@openshift-bot
Copy link

Evaluated for javaclient up to 6158bb6

openshift-bot pushed a commit that referenced this pull request Oct 16, 2013
Merge pull request #90 from adietish/JBIDE-15666
e8ff9ee 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit e8ff9ee into openshift:master Oct 16, 2013
@adietish adietish deleted the JBIDE-15666 branch October 16, 2013 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adietish @openshift-bot @xcoulon