New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM snapshots -WIP #183
VM snapshots -WIP #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ranelim Excellent job on a big topic! Added mostly nitpicky comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nit, and unsure if it needs to be changed, but the spacing between buttons the in the modals should be much less.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beanh66 should we be using Sentence style for new actions? I think we may have talked about this, but it makes the kebab menus look pretty inconsistent
Good question @serenamarie125, moving to sentence style will be a tricky change but that is the PF4 direction so need to figure out how to roll that out. All of our new designs should follow the PF4 topography standards. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ranelim this looks great! I just left a couple small updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewcarleton @Ranelim I left some comments inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for reviewing so late - thank you for adding this Ran. Some of these suggestions are related to the original design being a bit old, so maybe they can be fixed in a future update. FYI @matthewcarleton.
…g snapshots detail view to the same veiw before restoring from a snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, @Ranelim !
Snapshots allow users to create a copy of the VM disks and memory, mainly for restore and backup purposes. The snapshots are taken live or offline depending on if the VM is running or not.