Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating catalog designs #39

Merged
merged 2 commits into from
May 23, 2017
Merged

Updating catalog designs #39

merged 2 commits into from
May 23, 2017

Conversation

beanh66
Copy link
Member

@beanh66 beanh66 commented May 17, 2017

@serenamarie125 @rhamilto @cshinn @ncameronbritt Updated desktop and mobile design docs for the catalog subcategories. Please review and let me know what you think!

@rhamilto
Copy link
Member

@sg00dwin, you should probably review this, too.

@pmorie
Copy link

pmorie commented May 17, 2017 via email

@ncameronbritt
Copy link
Contributor

I said this already to @cshinn, but I think that animating the opening (and maybe closing) of the tiles could help clarify the interaction.

I'm also not sure that changing the way subcategories work for mobile is necessary. Seems like you could use the same tiles 2 or 3 wide at mobile. But I guess I see where that "back" action available at the top could be helpful if there lots of services or lots of subcategories.

@beanh66
Copy link
Member Author

beanh66 commented May 18, 2017

@ncameronbritt Great thought on the animation, I think @cshinn is working on that a bit.

Regarding the mobile, good point, we did just leave the tiles originally but we currently change the primary categories to a stacked list and it sounded like @rhamilto preferred implementing a consistent list format for both primary and secondary categories. I agree we shouldn't do this if it is a lot more effort on the dev side, but I'll leave that up to the developers to weigh in!

@serenamarie125
Copy link
Contributor

@beanh66 based on today's design review, should this be prefaced with [WIP]? I think that @cshinn was going to reach out to you and Jenny

@beanh66
Copy link
Member Author

beanh66 commented May 18, 2017

@serenamarie125 Good point, I'll change to WIP!

@beanh66 beanh66 changed the title Updating catalog designs [WIP] Updating catalog designs May 18, 2017
@beanh66 beanh66 changed the title [WIP] Updating catalog designs Updating catalog designs May 23, 2017
@serenamarie125
Copy link
Contributor

@beanh66 I think that we should merge this PR. Based on the latest review, there is an open item around how the UI looks when all subcategories are collapsed - Please open an Issue around that topic.

FYI @openshift/team-ux-review

@beanh66
Copy link
Member Author

beanh66 commented May 23, 2017

@serenamarie125 That makes sense. Here is the issue for the visual concerns around the default collapsed state of the subcategories: #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants