-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating catalog designs #39
Conversation
@sg00dwin, you should probably review this, too. |
That's weird, I don't see VB or COBOL in there anywhere.
…On Wed, May 17, 2017 at 4:22 PM, Robb Hamilton ***@***.***> wrote:
@sg00dwin <https://github.com/sg00dwin>, you should probably review this,
too.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWXmFj82VJpKKO0XNX4mqbQcqTH9hbdks5r61bygaJpZM4NeYWk>
.
|
I said this already to @cshinn, but I think that animating the opening (and maybe closing) of the tiles could help clarify the interaction. I'm also not sure that changing the way subcategories work for mobile is necessary. Seems like you could use the same tiles 2 or 3 wide at mobile. But I guess I see where that "back" action available at the top could be helpful if there lots of services or lots of subcategories. |
@ncameronbritt Great thought on the animation, I think @cshinn is working on that a bit. Regarding the mobile, good point, we did just leave the tiles originally but we currently change the primary categories to a stacked list and it sounded like @rhamilto preferred implementing a consistent list format for both primary and secondary categories. I agree we shouldn't do this if it is a lot more effort on the dev side, but I'll leave that up to the developers to weigh in! |
@serenamarie125 Good point, I'll change to WIP! |
@beanh66 I think that we should merge this PR. Based on the latest review, there is an open item around how the UI looks when all subcategories are collapsed - Please open an Issue around that topic. FYI @openshift/team-ux-review |
@serenamarie125 That makes sense. Here is the issue for the visual concerns around the default collapsed state of the subcategories: #41 |
@serenamarie125 @rhamilto @cshinn @ncameronbritt Updated desktop and mobile design docs for the catalog subcategories. Please review and let me know what you think!