[OSJC-244] Retrieve metadata from dockerhub v2 registry #124
Conversation
|
[test] |
jcantrill
force-pushed
the
244_metadata_from_dockerhub
branch
from
130c32e
to
61f19f3
Compare
|
[test] |
|
|
||
| @Override | ||
| public String getName() { | ||
| return DockerRegistryImageStreamImportCapability.class.getSimpleName(); |
There was a problem hiding this comment.
you could actually implement this in a base class that then does getClass().getSimpleName().
But since no other common functionality there's not much sense to it right now.
There was a problem hiding this comment.
Agreed. I don't actually recall why I added it into the original api.
jcantrill
force-pushed
the
244_metadata_from_dockerhub
branch
from
61f19f3
to
365ce2c
Compare
|
[test] |
| Map<String, String> auth = parseAuthDetails(details); | ||
| if(auth.containsKey(REALM)) { | ||
| Request request = client.newRequest(StringUtils.strip(auth.get(REALM),"\"")); | ||
| for (Entry<String, String> e: auth.entrySet()) { |
There was a problem hiding this comment.
ideal candidate for a method ex. addRealmParameters?
|
other than those design related comments, +1 |
jcantrill
force-pushed
the
244_metadata_from_dockerhub
branch
from
365ce2c
to
533555e
Compare
|
Evaluated for javaclient test up to 533555e |
|
[merge] |
|
Java Client Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/84/) |
|
Java Client Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge-openshift-restclient-java/77/) |
|
Evaluated for javaclient merge up to 533555e |
cc @fbricon @adietish