[OSJC-256] DefaultClient#equal <true> if authstrategies match in username #164
Conversation
adietish
changed the title
|
[test] |
|
@jcantrill dare to review? |
|
[test] |
|
weird, travis fails to build complainig that it cannot find the branch OSJC-256... |
adietish
force-pushed
the
OSJC-256
branch
2 times, most recently
from
e28f0cf
to
5a79081
Compare
| assertThat(tokenClient).isNotEqualTo(basicAuthClient); | ||
| } | ||
|
|
||
| @Test | ||
| public void client_should_equal_client_with_same_TokenAuthStrategy_with_different_token() throws Exception { |
There was a problem hiding this comment.
@adietish Looks like you lost a test
There was a problem hiding this comment.
@jcantrill nope, that's on purpose. See the method name, it says that 2 clients with different strategies should not be equal, that's exactly the opposite of what I wanted to change, so the test has to disappear.
|
LGTM. Per our conversation, I think equality should be obtained when the username and server match. Other then verifying the 'lost' test I think this is ok to merge. |
|
Evaluated for javaclient test up to 40935ea |
|
Java Client Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/123/) |
|
[merge] |
|
Java Client Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/125/) |
|
Evaluated for javaclient merge up to 40935ea |
No description provided.