[OSJC-225] Add watch support for resources #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .kind(kind) | ||
| .namespace(namespace) | ||
| .watch() | ||
| .addParmeter("resourceVersion", resourceVersion) |
There was a problem hiding this comment.
is addParmeter fixable without breaking everything?
There was a problem hiding this comment.
Not exactly sure what you mean here.
There was a problem hiding this comment.
typo in the method name addParmeter instead of addParameter. if it's a public method, then renaming it would be problematic for backward compat.
jcantrill
force-pushed
the
225_add_watch
branch
from
bfa7673
to
070ed25
Compare
|
[merge] |
|
Java Client Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge-openshift-restclient-java/40/) |
|
Evaluated for javaclient merge up to 070ed25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fbricon @adietish Please review