[OSJC-226] refactor watch to use websockets #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
| public String websocket() { | ||
| String url = build().toString(); | ||
| url = "wss" + url.substring(url.indexOf(":")); | ||
| LOG.debug(String.format("Built url: %s", url)); |
There was a problem hiding this comment.
LOG.debug("Built url: {}", url);
so that .format() doesn't get evaluated if not in debug mode
There was a problem hiding this comment.
it will always be evaluated. prefer i add in a 'isDebug' ?
jcantrill
force-pushed
the
refactor_watch_use_websockets
branch
from
a638866
to
68d0650
Compare
|
Java Client Test Results: Running (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/45/) |
jcantrill
force-pushed
the
refactor_watch_use_websockets
branch
from
68d0650
to
3f5be8a
Compare
|
[merge] |
|
Java Client Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge-openshift-restclient-java/45/) |
|
Evaluated for javaclient merge up to 3f5be8a |
|
Evaluated for javaclient test up to 3f5be8a |
openshift-bot
pushed a commit
that referenced
this pull request
Nov 10, 2015
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.