Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-23649: bump dependencies #109

Merged
merged 1 commit into from Nov 28, 2023
Merged

OCPBUGS-23649: bump dependencies #109

merged 1 commit into from Nov 28, 2023

Conversation

simonpasquier
Copy link
Contributor

This commit updates the modules listed in go.mod to get rid of the indirect dependency on github.com/Azure/go-autorest.

@simonpasquier
OCPBUGS-23649: bump dependencies
82a6c74 
This commit updates the modules listed in go.mod to get rid of the
indirect dependency on `github.com/Azure/go-autorest`.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2023
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: This pull request references Jira Issue OCPBUGS-23649, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit updates the modules listed in go.mod to get rid of the indirect dependency on github.com/Azure/go-autorest.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor Author

/jira refresh

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@simonpasquier
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 24, 2023
@simonpasquier
Copy link
Contributor Author

/cc @jan--f

@simonpasquier
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2023
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: This pull request references Jira Issue OCPBUGS-23649, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao November 24, 2023 11:06
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 24, 2023

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor Author

/cc @jan--f

@rexagod
Copy link
Member

rexagod commented Nov 28, 2023

/lgtm
/hold
For others to take a look.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rexagod
Copy link
Member

rexagod commented Nov 28, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 6369e3a into openshift:master Nov 28, 2023
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: Jira Issue OCPBUGS-23649: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23649 has been moved to the MODIFIED state.

In response to this:

This commit updates the modules listed in go.mod to get rid of the indirect dependency on github.com/Azure/go-autorest.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-state-metrics-container-v4.15.0-202311282232.p0.g6369e3a.assembly.stream for distgit openshift-state-metrics.
All builds following this will include this PR.

@simonpasquier simonpasquier deleted the OCPBUGS-23649 branch November 29, 2023 10:01
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@rexagod rexagod

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@simonpasquier @openshift-ci-robot @rexagod @openshift-bot @openshift-merge-robot