deploy_defaults.go

package controller_manager

import (
	"reflect"
	"time"

	g "github.com/onsi/ginkgo"

	appsv1 "github.com/openshift/api/apps/v1"
	exutil "github.com/openshift/openshift-tests/test/extended/util"
	corev1 "k8s.io/api/core/v1"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
	"k8s.io/apimachinery/pkg/util/diff"
	"k8s.io/apimachinery/pkg/util/intstr"
)

var (
	nonDefaultRevisionHistoryLimit = int32(52)
)

func minimalDC(name string, generation int64) *appsv1.DeploymentConfig {
	return &appsv1.DeploymentConfig{
		ObjectMeta: metav1.ObjectMeta{
			Name:       name,
			Generation: generation,
		},
		Spec: appsv1.DeploymentConfigSpec{
			Selector: map[string]string{
				"app": name,
			},
			Template: &corev1.PodTemplateSpec{
				ObjectMeta: metav1.ObjectMeta{
					Labels: map[string]string{
						"app": name,
					},
				},
				Spec: corev1.PodSpec{
					Containers: []corev1.Container{
						{
							Name:  "a",
							Image: " ",
						},
					},
				},
			},
		},
	}
}

func int64ptr(v int64) *int64 {
	return &v
}

func int32ptr(v int32) *int32 {
	return &v
}

func setEssentialDefaults(dc *appsv1.DeploymentConfig) *appsv1.DeploymentConfig {
	dc.Spec.Strategy.Type = appsv1.DeploymentStrategyTypeRolling
	twentyFivePerc := intstr.FromString("25%")
	dc.Spec.Strategy.RollingParams = &appsv1.RollingDeploymentStrategyParams{
		IntervalSeconds:     int64ptr(1),
		UpdatePeriodSeconds: int64ptr(1),
		TimeoutSeconds:      int64ptr(600),
		MaxUnavailable:      &twentyFivePerc,
		MaxSurge:            &twentyFivePerc,
	}
	dc.Spec.Strategy.ActiveDeadlineSeconds = int64ptr(21600)
	dc.Spec.Triggers = []appsv1.DeploymentTriggerPolicy{
		{Type: appsv1.DeploymentTriggerOnConfigChange},
	}
	dc.Spec.Template.Spec.Containers[0].TerminationMessagePath = "/dev/termination-log"
	dc.Spec.Template.Spec.Containers[0].TerminationMessagePolicy = "File"
	dc.Spec.Template.Spec.Containers[0].ImagePullPolicy = "IfNotPresent"
	dc.Spec.Template.Spec.SecurityContext = &corev1.PodSecurityContext{}
	dc.Spec.Template.Spec.RestartPolicy = "Always"
	dc.Spec.Template.Spec.TerminationGracePeriodSeconds = int64ptr(30)
	dc.Spec.Template.Spec.DNSPolicy = "ClusterFirst"
	dc.Spec.Template.Spec.HostNetwork = false
	dc.Spec.Template.Spec.HostPID = false
	dc.Spec.Template.Spec.HostIPC = false
	dc.Spec.Template.Spec.SchedulerName = "default-scheduler"

	return dc
}

func clearTransient(dc *appsv1.DeploymentConfig) {
	dc.ObjectMeta.Namespace = ""
	dc.ObjectMeta.SelfLink = ""
	dc.ObjectMeta.UID = ""
	dc.ObjectMeta.ResourceVersion = ""
	dc.ObjectMeta.CreationTimestamp.Time = time.Time{}
}

var _ = g.Describe("[Feature:OpenShiftControllerManager]", func() {
	defer g.GinkgoRecover()
	oc := exutil.NewCLI("deployment-defaults", exutil.KubeConfigPath())

	g.It("TestDeploymentConfigDefaults", func() {
		t := g.GinkgoT()

		namespace := oc.Namespace()
		appsClient := oc.AdminAppsClient()

		ttApps := []struct {
			obj  *appsv1.DeploymentConfig
			apps *appsv1.DeploymentConfig
		}{
			{
				obj: func() *appsv1.DeploymentConfig {
					dc := minimalDC("test-apps-01", 0)
					dc.Spec.RevisionHistoryLimit = nil
					return dc
				}(),
				apps: func() *appsv1.DeploymentConfig {
					dc := minimalDC("test-apps-01", 1)
					setEssentialDefaults(dc)
					// Group API should default RevisionHistoryLimit
					dc.Spec.RevisionHistoryLimit = int32ptr(10)
					return dc
				}(),
			},
			{
				obj: func() *appsv1.DeploymentConfig {
					dc := minimalDC("test-apps-02", 0)
					dc.Spec.RevisionHistoryLimit = &nonDefaultRevisionHistoryLimit
					return dc
				}(),
				apps: func() *appsv1.DeploymentConfig {
					dc := minimalDC("test-apps-02", 1)
					setEssentialDefaults(dc)
					dc.Spec.RevisionHistoryLimit = &nonDefaultRevisionHistoryLimit
					return dc
				}(),
			},
		}
		for _, tc := range ttApps {
			appsDC, err := appsClient.AppsV1().DeploymentConfigs(namespace).Create(tc.obj)
			if err != nil {
				t.Fatalf("Failed to create DC: %v", err)
			}

			clearTransient(appsDC)
			if !reflect.DeepEqual(appsDC, tc.apps) {
				t.Errorf("Apps DC differs from expected output: %s", diff.ObjectReflectDiff(appsDC, tc.apps))
			}
		}
	})
})