Refactoring to use profiles.tuned.openshift.io #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmencak
requested review from
zvonkok,
courtneypacheco,
sjug and
Deepthidharwar
openshift-ci-robot
added
do-not-merge/work-in-progress
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Looking good for me, this rework makes the operand as dumb as possible, the new informer and new design will minimize API access and resolve the issue with slow propagation of tuned profiles. |
|
/lgtm |
This is a largish refactoring of the NTO's operand, openshift-tuned.
Changes:
- Do not pull any node/pod information from the API server. Use
a shared informer for profiles.tuned.openshift.io objects which
carry a precalculated tuned profile for the node.
- Switch to klog, glog seems unmaintained and vendored-in libraries
already depend on klog.
- Added tuna and tuned-profiles-cpu-partitioning profiles
- Redesign of the retry loop
- Makefile/.gitignore cleanup
- Added vendor dependencies
- Bump the OCP base to 4.4, tuned patches maintenance
jmencak
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, sjug The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a largish refactoring of the NTO's operand, openshift-tuned.
Changes:
a shared informer for profiles.tuned.openshift.io objects which
carry a precalculated tuned profile for the node.
already depend on klog.