Support for the "rendered" Tuned CR. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/L
|
@sjug, PTAL |
|
I will cancel the hold when both PRs are ready to merge |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Recent NTO stops using ConfigMaps to communicate profile changes between the operator and this operands. This change adds support for the "rendered" Tuned CR which is now used by the operator to inform the operand about the global tuned profile changes. Support for the old way of communicating the changes (ConfigMaps) is still present, but will be removed soon.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, sjug The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent NTO stops using ConfigMaps to communicate profile changes between
the operator and this operands. This change adds support for the "rendered"
Tuned CR which is now used by the operator to inform the operand about
the global tuned profile changes. Support for the old way of communicating
the changes (ConfigMaps) is still present, but will be removed soon.
Companion PR: openshift/cluster-node-tuning-operator#98