Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2074675: Fixing HPA not converting apiGroup for deploymentconfigs (#126) #132

Merged
merged 1 commit into from Apr 21, 2022
Merged

Bug 2074675: Fixing HPA not converting apiGroup for deploymentconfigs (#126) #132

merged 1 commit into from Apr 21, 2022

Conversation

rayfordj
Copy link
Contributor

  • Fixing HPA not converting apiGroup for deploymentconfigs

  • Fixing typos

  • Update velero-plugins/horizontalpodautoscaler/restore.go

Co-authored-by: Pranav Gaikwad pgaikwad@redhat.com

  • Update velero-plugins/horizontalpodautoscaler/restore.go

Co-authored-by: Pranav Gaikwad pgaikwad@redhat.com

  • Throwing error when it's not possible to parse APIVersion of hpa.spec.scaleTargetRef

  • Excluding HPA from common restore plugin

Co-authored-by: Adriano Marcondes Machado admachad@redhat.com
Co-authored-by: Pranav Gaikwad pgaikwad@redhat.com

@ammachado @pranavgaikwad @rayfordj
Fixing HPA not converting apiGroup for deploymentconfigs (openshift#126)
555c174 
* Fixing HPA not converting apiGroup for deploymentconfigs

* Fixing typos

* Update velero-plugins/horizontalpodautoscaler/restore.go

Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>

* Update velero-plugins/horizontalpodautoscaler/restore.go

Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>

* Throwing error when it's not possible to parse APIVersion of hpa.spec.scaleTargetRef

* Excluding HPA from common restore plugin

Co-authored-by: Adriano Marcondes Machado <admachad@redhat.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
@rayfordj rayfordj self-assigned this Apr 20, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2022

@rayfordj: This pull request references Bugzilla bug 2074675, which is invalid:

  • expected dependent Bugzilla bug 2072311 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2074675: Fixing HPA not converting apiGroup for deploymentconfigs (#126)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 20, 2022
@rayfordj
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2022
@rayfordj
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2022
@rayfordj rayfordj merged commit 3a99047 into openshift:release-1.7.1 Apr 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 21, 2022

@rayfordj: All pull requests linked via external trackers have merged:

Bugzilla bug 2074675 has been moved to the MODIFIED state.

In response to this:

Bug 2074675: Fixing HPA not converting apiGroup for deploymentconfigs (#126)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayfordj rayfordj deleted the pick-bz2074675 branch April 21, 2022 13:59
@kaovilai kaovilai mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavgaikwad pranavgaikwad pranavgaikwad approved these changes

@sseago sseago Awaiting requested review from sseago

Assignees

@rayfordj rayfordj

Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rayfordj @pranavgaikwad @ammachado