Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-602 Create keyfile for each secret name for GCS Registry Driver #163

Merged
merged 3 commits into from Aug 10, 2022

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Aug 9, 2022

Fixes registry failures on imagestream backups when velero deployment created does not have GCS secret mounted ie. no VSL specified.
This PR create a keyfile for each secret name used in GCP BSL so we can give a path to registry GCS driver

OADP-602

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2022
@kaovilai kaovilai changed the title OADP-602 Remove keyfile usage from GCS Registry Driver OADP-602 Create keyfile for each secret name for GCS Registry Driver Aug 9, 2022
@kaovilai kaovilai marked this pull request as ready for review August 9, 2022 23:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2022
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants