Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-1075 Add annotation to exclude build pod volumes during backup #171

Merged
merged 1 commit into from Apr 12, 2023
Merged

OADP-1075 Add annotation to exclude build pod volumes during backup #171

merged 1 commit into from Apr 12, 2023

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Jan 17, 2023 •
edited

OADP-1075

and update udistribution with dependabot updates.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2023
@kaovilai kaovilai marked this pull request as ready for review January 17, 2023 22:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2023
sseago
sseago requested changes Jan 23, 2023
View reviewed changes
velero-plugins/pod/backup.go Outdated Show resolved Hide resolved
velero-plugins/pod/backup.go Outdated Show resolved Hide resolved
velero-plugins/pod/backup.go Outdated Show resolved Hide resolved
velero-plugins/pod/backup.go Outdated Show resolved Hide resolved
@kaovilai
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@kaovilai kaovilai force-pushed the oadp-1075 branch 3 times, most recently from 9ab3b41 to de3c885 Compare April 12, 2023 16:29
@kaovilai kaovilai requested a review from sseago April 12, 2023 16:31
kaovilai
kaovilai commented Apr 12, 2023
View reviewed changes
go.mod
github.com/kaovilai/udistribution v0.0.7-oadp-1.1
github.com/google/go-cmp v0.5.9
github.com/hashicorp/go-hclog v1.0.0 // indirect
github.com/kaovilai/udistribution v0.0.9-oadp-1.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating udistribution which have dependabot updates. keep this here or separate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were other go.mod additions so figured why not in one go.

sseago
sseago reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@sseago sseago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine, just one additional minor change suggested

velero-plugins/pod/backup.go Outdated Show resolved Hide resolved
@kaovilai
Add annotation to exclude build pod volumes during backup
e45cc78 
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

comment typo imagestreams -> pods

go mod updates

formatting and nil annotations handling

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai requested a review from sseago April 12, 2023 17:03
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@kaovilai
Copy link
Member Author

/unhold
/cherry-pick oadp-1.2

@openshift-cherrypick-robot
Copy link

@kaovilai: once the present PR merges, I will cherry-pick it on top of oadp-1.2 in a new PR and assign it to you.

In response to this:

/unhold
/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2023

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eemcmullan, kaovilai, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [eemcmullan,kaovilai,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Copy link
Member Author

in 5 minutes or so, travis should finish and we may witness a tide automerge!

@openshift-merge-robot openshift-merge-robot merged commit a7b9405 into openshift:master Apr 12, 2023
4 checks passed
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 12, 2023
Merged
@openshift-cherrypick-robot
Copy link

@kaovilai: new pull request created: #189

In response to this:

/unhold
/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sseago sseago sseago approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@eemcmullan eemcmullan eemcmullan approved these changes

Assignees

@sseago sseago

@shubham-pampattiwar shubham-pampattiwar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kaovilai @openshift-cherrypick-robot @sseago @shubham-pampattiwar @eemcmullan @openshift-merge-robot