Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "STOR-1065: Rework sidecar bindings to bind common ClusterRoles" #118

Conversation

dgoodwin
Copy link
Contributor

Reverts #117

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 21, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 21, 2023

@dgoodwin: This pull request references STOR-1065 which is a valid jira issue.

In response to this:

Reverts #117

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgoodwin
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DennisPeriquet
Copy link

/lgtm

@dgoodwin
Copy link
Contributor Author

Based on feedback from @jsafrane we believe it's best to revert all changes related to this jira that went into the affected payloads.

/override ci/prow/e2e-openstack
/override ci/prow/e2e-openstack-csi
/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-openstack, ci/prow/e2e-openstack-csi

In response to this:

Based on feedback from @jsafrane we believe it's best to revert all changes related to this jira that went into the affected payloads.

/override ci/prow/e2e-openstack
/override ci/prow/e2e-openstack-csi
/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit bbb55ff into openshift:master Jul 21, 2023
6 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mpatlasov added a commit to mpatlasov/openstack-cinder-csi-driver-operator that referenced this pull request Jul 24, 2023
…ind common ClusterRoles"

PR openshift#118 (openshift#118) reverted "STOR-1065: Rework sidecar bindings to bind common ClusterRoles" as the safest way back to a known good state after nigltly CI tests detected that storage operator is degraded on all gcp and azure installs upgrades.

Openstack-cinder is immune to those issues. Let's bring "STOR-1065: Rework sidecar bindings to bind common ClusterRoles" back now.
mpatlasov added a commit to mpatlasov/openstack-cinder-csi-driver-operator that referenced this pull request Jul 28, 2023
…ind common ClusterRoles"

PR openshift#118 (openshift#118) reverted "STOR-1065: Rework sidecar bindings to bind common ClusterRoles" as the safest way back to a known good state after nigltly CI tests detected that storage operator is degraded on all gcp and azure installs upgrades.

Openstack-cinder is immune to those issues. Let's bring "STOR-1065: Rework sidecar bindings to bind common ClusterRoles" back now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants