Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16678: Fix SCC admission failure race during initial deployment #120

Merged
merged 1 commit into from Jul 25, 2023

Conversation

mandre
Copy link
Member

@mandre mandre commented Jul 24, 2023

RBAC rules should be created before their ServiceAccounts, so SCC admission has all of them present when validating a Pod + its ServiceAccount.

RBAC rules should be created before their ServiceAccounts, so SCC
admission has all of them present when validating a Pod + its
ServiceAccount.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 24, 2023
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Jira Issue OCPBUGS-16678, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

RBAC rules should be created before their ServiceAccounts, so SCC admission has all of them present when validating a Pod + its ServiceAccount.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@mandre
Copy link
Member Author

mandre commented Jul 24, 2023

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dulek
Copy link

dulek commented Jul 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit a95a609 into openshift:master Jul 25, 2023
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@mandre: Jira Issue OCPBUGS-16678: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16678 has been moved to the MODIFIED state.

In response to this:

RBAC rules should be created before their ServiceAccounts, so SCC admission has all of them present when validating a Pod + its ServiceAccount.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM deleted the rbac-race branch July 27, 2023 13:13
@EmilienM
Copy link
Member

should we backport this?

@mandre
Copy link
Member Author

mandre commented Jul 31, 2023

should we backport this?

Yep, it was my intention.

@mandre
Copy link
Member Author

mandre commented Jul 31, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot

@mandre: new pull request created: #124

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants