Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure User Agent #123

Merged
merged 1 commit into from Aug 1, 2023

Conversation

stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Jul 28, 2023

This can be a helpful breadcrumb when debugging services.

Note that the version information ldflags are populated by build-machinery-go, which provides e.g. the build makefile target.

Signed-off-by: Stephen Finucane stephenfin@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
This can be a helpful breadcrumb when debugging services.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
Copy link
Contributor Author

/cc @mandre
/cc @mdbooth

@openshift-ci openshift-ci bot requested review from mandre and mdbooth July 31, 2023 12:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as intended. Here is what we saw in the logs:

/var/log/containers/httpd/cinder-api/cinder_wsgi_access.log.1:192.168.24.1 - - [31/Jul/2023:12:18:25 +0000] "GET /v3/7dbb1674a36d4954a9e2b20c25f9b770/os-availability-zone HTTP/1.1" 200 105 "-" "openstack-cinder-csi-driver-operator/b31430b2 gophercloud/2.0.0"

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d35f6d1 into openshift:master Aug 1, 2023
6 checks passed
@stephenfin stephenfin deleted the add-user-agent branch August 1, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants