Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1436: Restart openstack-cinder-csi-driver-controller Pods if metrics-serving-cert changed #128

Merged
merged 1 commit into from Aug 8, 2023

Conversation

Phaow
Copy link
Contributor

@Phaow Phaow commented Aug 7, 2023

STOR-1436: Restart openstack-cinder-csi-driver-controller Pods if metrics-serving-cert changed

  • Adding WithSecretHashAnnotationHook() for openstack-cinder-csi-driver-controller ensures that new annotation is published in openstack-cinder-csi-driver-controller deployment. This, in turn, leads to controller pods restart.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2023

@Phaow: This pull request references STOR-1436 which is a valid jira issue.

In response to this:

STOR-1436: Restart openstack-cinder-csi-driver-controller Pods if metrics-serving-cert changed

  • Adding WithSecretHashAnnotationHook() for openstack-cinder-csi-driver-controller ensures that new annotation is published in openstack-cinder-csi-driver-controller deployment. This, in turn, leads to controller pods restart.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Phaow
Copy link
Contributor Author

Phaow commented Aug 7, 2023

/assign @mpatlasov

@mpatlasov
Copy link
Contributor

/test e2e-openstack

@mpatlasov
Copy link
Contributor

/approved
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

@Phaow: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Phaow
Copy link
Contributor Author

Phaow commented Aug 8, 2023

Pre verifiy passed with the pre merged build 4.14.0-0.ci.test-2023-08-08-022420-ci-ln-vdfxwgt-latest

# After the metrics-serving-cert secret changed, driver controller restarted
$ oc delete secret/openstack-cinder-csi-driver-controller-metrics-serving-cert
secret "openstack-cinder-csi-driver-controller-metrics-serving-cert" deleted

$ oc get po -l app=openstack-cinder-csi-driver-controller -w
NAME                                                      READY   STATUS    RESTARTS   AGE
openstack-cinder-csi-driver-controller-6bdbdddc75-9cl6f   10/10   Running   0          5h46m
openstack-cinder-csi-driver-controller-6bdbdddc75-pwfwk   10/10   Running   0          5h48m
openstack-cinder-csi-driver-controller-6bdbdddc75-pwfwk   10/10   Terminating   0          5h49m
openstack-cinder-csi-driver-controller-784d898d4c-ddkbj   0/10    Pending       0          0s
openstack-cinder-csi-driver-controller-784d898d4c-ddkbj   0/10    Pending       0          0s
openstack-cinder-csi-driver-controller-784d898d4c-ddkbj   0/10    ContainerCreating   0          0s
openstack-cinder-csi-driver-controller-784d898d4c-ddkbj   0/10    Terminating         0          0s
openstack-cinder-csi-driver-controller-6dc8587d76-8bqdp   0/10    Pending             0          0s
openstack-cinder-csi-driver-controller-6dc8587d76-8bqdp   0/10    Pending             0          0s
openstack-cinder-csi-driver-controller-6bdbdddc75-pwfwk   0/10    Terminating         0          5h49m
openstack-cinder-csi-driver-controller-6dc8587d76-8bqdp   0/10    Pending             0          1s
openstack-cinder-csi-driver-controller-6dc8587d76-8bqdp   0/10    ContainerCreating   0          1s
openstack-cinder-csi-driver-controller-6bdbdddc75-pwfwk   0/10    Terminating         0          5h49m
openstack-cinder-csi-driver-controller-6bdbdddc75-pwfwk   0/10    Terminating         0          5h49m
openstack-cinder-csi-driver-controller-784d898d4c-ddkbj   10/10   Terminating         0          3s
openstack-cinder-csi-driver-controller-784d898d4c-ddkbj   0/10    Terminating         0          3s
openstack-cinder-csi-driver-controller-784d898d4c-ddkbj   0/10    Terminating         0          4s
openstack-cinder-csi-driver-controller-784d898d4c-ddkbj   0/10    Terminating         0          4s
openstack-cinder-csi-driver-controller-6dc8587d76-8bqdp   10/10   Running             0          5s
openstack-cinder-csi-driver-controller-6bdbdddc75-9cl6f   10/10   Terminating         0          5h47m
openstack-cinder-csi-driver-controller-6dc8587d76-8vqn5   0/10    Pending             0          0s
openstack-cinder-csi-driver-controller-6dc8587d76-8vqn5   0/10    Pending             0          0s
openstack-cinder-csi-driver-controller-6dc8587d76-8vqn5   0/10    ContainerCreating   0          0s
openstack-cinder-csi-driver-controller-6bdbdddc75-9cl6f   0/10    Terminating         0          5h47m
openstack-cinder-csi-driver-controller-6bdbdddc75-9cl6f   0/10    Terminating         0          5h47m
openstack-cinder-csi-driver-controller-6bdbdddc75-9cl6f   0/10    Terminating         0          5h47m
openstack-cinder-csi-driver-controller-6dc8587d76-8vqn5   10/10   Running             0          3s

$ oc get po -l app=openstack-cinder-csi-driver-controller
NAME                                                      READY   STATUS    RESTARTS   AGE
openstack-cinder-csi-driver-controller-6dc8587d76-8bqdp   10/10   Running   0          21s
openstack-cinder-csi-driver-controller-6dc8587d76-8vqn5   10/10   Running   0          16s

@Phaow
Copy link
Contributor Author

Phaow commented Aug 8, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 8, 2023
@mpatlasov
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5e20bfc into openshift:master Aug 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants