OCPBUGS-24226: setting TLSSecurityProfile with no minTLSVersion crashes controller

[dobsonj]

bump library-go to get the fix in commit 4a819e39ef45daa1f9a800434082f93e0b4b227a

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-24226, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bump library-go to get the fix in commit 4a819e39ef45daa1f9a800434082f93e0b4b227a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dobsonj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dobsonj]

/retest

[RomanBednar]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fe1b430 and 2 for PR HEAD 017e970 in total

[duanwei33]

Tested with open PR, it works when setting cipherSuites without minTLSVersion

2. TLS profile in clustercsidriver

$ oc get clustercsidriver -o json cinder.csi.openstack.org | jq .spec.observedConfig.targetcsiconfig.servingInfo
{
  "cipherSuites": [
    "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256",
    "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256"
  ],
  "minTLSVersion": ""
}

3. TLS profile in csi driver controller:

$ oc -n openshift-cluster-csi-drivers get deployment openstack-cinder-csi-driver-controller -o json | jq .spec.template.spec.containers[] | jq 'select(.name | match(".*kube-rbac-proxy.*")) | {container: .name, arg: .args}'
{
  "container": "provisioner-kube-rbac-proxy",
  "arg": [
    "--secure-listen-address=0.0.0.0:9202",
    "--upstream=http://127.0.0.1:8202/",
    "--tls-cert-file=/etc/tls/private/tls.crt",
    "--tls-private-key-file=/etc/tls/private/tls.key",
    "--tls-cipher-suites=TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
    "--tls-min-version=VersionTLS12",
    "--logtostderr=true"
  ]
}
{
  "container": "attacher-kube-rbac-proxy",
  "arg": [
    "--secure-listen-address=0.0.0.0:9203",
    "--upstream=http://127.0.0.1:8203/",
    "--tls-cert-file=/etc/tls/private/tls.crt",
    "--tls-private-key-file=/etc/tls/private/tls.key",
    "--tls-cipher-suites=TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
    "--tls-min-version=VersionTLS12",
    "--logtostderr=true"
  ]
}
{
  "container": "resizer-kube-rbac-proxy",
  "arg": [
    "--secure-listen-address=0.0.0.0:9204",
    "--upstream=http://127.0.0.1:8204/",
    "--tls-cert-file=/etc/tls/private/tls.crt",
    "--tls-private-key-file=/etc/tls/private/tls.key",
    "--tls-cipher-suites=TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
    "--tls-min-version=VersionTLS12",
    "--logtostderr=true"
  ]
}
{
  "container": "snapshotter-kube-rbac-proxy",
  "arg": [
    "--secure-listen-address=0.0.0.0:9205",
    "--upstream=http://127.0.0.1:8205/",
    "--tls-cert-file=/etc/tls/private/tls.crt",
    "--tls-private-key-file=/etc/tls/private/tls.key",
    "--tls-cipher-suites=TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
    "--tls-min-version=VersionTLS12",
    "--logtostderr=true"
  ]
}

4. TLS profile is used in container:

The container provisioner-kube-rbac-proxy in pod openstack-cinder-csi-driver-controller-79dddc9454-4v9w9:
nobody         1       0  0 12:07 ?        00:00:00 /usr/bin/kube-rbac-proxy --secure-listen-address=0.0.0.0:9202 --upstream=http://127.0.0.1:8202/ --tls-cert-file=/etc/tls/private/tls.crt --tls-private-key-file=/etc/tls/private/tls.key --tls-cipher-suites=TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 --tls-min-version=VersionTLS12 --logtostderr=true
-------------------------------------------
The container attacher-kube-rbac-proxy in pod openstack-cinder-csi-driver-controller-79dddc9454-4v9w9:
nobody         1       0  0 12:07 ?        00:00:00 /usr/bin/kube-rbac-proxy --secure-listen-address=0.0.0.0:9203 --upstream=http://127.0.0.1:8203/ --tls-cert-file=/etc/tls/private/tls.crt --tls-private-key-file=/etc/tls/private/tls.key --tls-cipher-suites=TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 --tls-min-version=VersionTLS12 --logtostderr=true
-------------------------------------------
The container resizer-kube-rbac-proxy in pod openstack-cinder-csi-driver-controller-79dddc9454-4v9w9:
nobody         1       0  0 12:07 ?        00:00:00 /usr/bin/kube-rbac-proxy --secure-listen-address=0.0.0.0:9204 --upstream=http://127.0.0.1:8204/ --tls-cert-file=/etc/tls/private/tls.crt --tls-private-key-file=/etc/tls/private/tls.key --tls-cipher-suites=TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 --tls-min-version=VersionTLS12 --logtostderr=true
-------------------------------------------
The container snapshotter-kube-rbac-proxy in pod openstack-cinder-csi-driver-controller-79dddc9454-4v9w9:
nobody         1       0  0 12:07 ?        00:00:00 /usr/bin/kube-rbac-proxy --secure-listen-address=0.0.0.0:9205 --upstream=http://127.0.0.1:8205/ --tls-cert-file=/etc/tls/private/tls.crt --tls-private-key-file=/etc/tls/private/tls.key --tls-cipher-suites=TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 --tls-min-version=VersionTLS12 --logtostderr=true

[duanwei33]

/label qe-approved

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-24226, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

bump library-go to get the fix in commit 4a819e39ef45daa1f9a800434082f93e0b4b227a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dobsonj]

/retest

[dobsonj]

/retest

[dobsonj]

/retest

[dobsonj]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2874f68 and 1 for PR HEAD 017e970 in total

[dobsonj]

/retest

[dobsonj]

/override ci/prow/e2e-openstack-csi

[openshift-ci]

@dobsonj: Overrode contexts on behalf of dobsonj: ci/prow/e2e-openstack-csi

In response to this:

/override ci/prow/e2e-openstack-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@dobsonj: Jira Issue OCPBUGS-24226: All pull requests linked via external trackers have merged:

• openshift/library-go#1636
• openshift/csi-operator#76
• openshift/gcp-pd-csi-driver-operator#104
• openshift/alibaba-disk-csi-driver-operator#78
• openshift/azure-file-csi-driver-operator#91
• openshift/csi-driver-manila-operator#217
• openshift/gcp-filestore-csi-driver-operator#69
• openshift/openstack-cinder-csi-driver-operator#150
• openshift/vmware-vsphere-csi-driver-operator#201
• openshift/aws-efs-csi-driver-operator#108
• openshift/azure-disk-csi-driver-operator#116

Jira Issue OCPBUGS-24226 has been moved to the MODIFIED state.

In response to this:

bump library-go to get the fix in commit 4a819e39ef45daa1f9a800434082f93e0b4b227a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.