Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30951: Relax requirement to enable topology #164

Merged
merged 1 commit into from Apr 11, 2024

Conversation

mandre
Copy link
Member

@mandre mandre commented Mar 15, 2024

The only requirement is that for every compute zone we have a matching volume zone with the same name. It's perfectly fine to have extra volume zones, as the scheduler won't provision volumes on them.

It is still possible for users to overwrite that default and set the enable_topology key to the desired value in the
openshift-config/cloud-provider-config config map.

The only requirement is that for every compute zone we have a matching
volume zone with the same name. It's perfectly fine to have extra volume
zones, as the scheduler won't provision volumes on them.

It is still possible for users to overwrite that default and set the
`enable_topology` key to the desired value in the
`openshift-config/cloud-provider-config` config map.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 15, 2024
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Jira Issue OCPBUGS-30951, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The only requirement is that for every compute zone we have a matching volume zone with the same name. It's perfectly fine to have extra volume zones, as the scheduler won't provision volumes on them.

It is still possible for users to overwrite that default and set the enable_topology key to the desired value in the
openshift-config/cloud-provider-config config map.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mandre
Copy link
Member Author

mandre commented Mar 15, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 15, 2024
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Jira Issue OCPBUGS-30951, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
Copy link
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. CI failure looks unrelated also.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 97c2f9a and 2 for PR HEAD 12a78f0 in total

@mandre
Copy link
Member Author

mandre commented Apr 9, 2024

/test e2e-openstack-csi

1 similar comment
@mandre
Copy link
Member Author

mandre commented Apr 11, 2024

/test e2e-openstack-csi

Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2c6f7f9 into openshift:master Apr 11, 2024
7 checks passed
@mandre mandre deleted the topology-check branch April 11, 2024 15:43
@mandre
Copy link
Member Author

mandre commented Apr 11, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@mandre: new pull request created: #165

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@mandre: An error was encountered updating to the MODIFIED state for bug OCPBUGS-30951 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. No response returned: Post "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-30951/transitions": POST https://issues.redhat.com/rest/api/2/issue/OCPBUGS-30951/transitions giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

The only requirement is that for every compute zone we have a matching volume zone with the same name. It's perfectly fine to have extra volume zones, as the scheduler won't provision volumes on them.

It is still possible for users to overwrite that default and set the enable_topology key to the desired value in the
openshift-config/cloud-provider-config config map.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openstack-cinder-csi-driver-operator-container-v4.16.0-202404120544.p0.g2c6f7f9.assembly.stream.el9 for distgit ose-openstack-cinder-csi-driver-operator.
All builds following this will include this PR.

@mandre
Copy link
Member Author

mandre commented Apr 23, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mandre: Jira Issue OCPBUGS-30951: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30951 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants