New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30951: Relax requirement to enable topology #164
OCPBUGS-30951: Relax requirement to enable topology #164
Conversation
The only requirement is that for every compute zone we have a matching volume zone with the same name. It's perfectly fine to have extra volume zones, as the scheduler won't provision volumes on them. It is still possible for users to overwrite that default and set the `enable_topology` key to the desired value in the `openshift-config/cloud-provider-config` config map.
@mandre: This pull request references Jira Issue OCPBUGS-30951, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@mandre: This pull request references Jira Issue OCPBUGS-30951, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. CI failure looks unrelated also.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-openstack-csi |
1 similar comment
/test e2e-openstack-csi |
@mandre: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherry-pick release-4.15 |
@mandre: new pull request created: #165 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mandre: An error was encountered updating to the MODIFIED state for bug OCPBUGS-30951 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Post "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-30951/transitions": POST https://issues.redhat.com/rest/api/2/issue/OCPBUGS-30951/transitions giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-openstack-cinder-csi-driver-operator-container-v4.16.0-202404120544.p0.g2c6f7f9.assembly.stream.el9 for distgit ose-openstack-cinder-csi-driver-operator. |
/jira refresh |
@mandre: Jira Issue OCPBUGS-30951: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30951 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The only requirement is that for every compute zone we have a matching volume zone with the same name. It's perfectly fine to have extra volume zones, as the scheduler won't provision volumes on them.
It is still possible for users to overwrite that default and set the
enable_topology
key to the desired value in theopenshift-config/cloud-provider-config
config map.