OCPBUGS-15235: [iRMC] Fix IPMI incompatibility handling error

[hroyrh]

This patch deals with overlooked situation in patch d23f72e, in which irmc_ipmi_succeed flag is added to deal with iRMC firmware's IPMI incompatibility introduced at iRMC firmware version S6 2.00 and later.
That flag is set and updated by irmc power_interface code and rest of iRMC driver code use that flag.

When ipmitool is set as power_interface, that flag is not set nor updated and rest of iRMC driver code fail to handle IPMI incompatibility correctly.

This patch adds logic to check power_interface to
make iRMC driver properly deal with iRMC firmware's IPMI incompatibility even when ipmitool power_interface is used.

Change-Id: Id353c4f5260a7c469779b50ad302f442223df5a0 (cherry picked from commit 27bf209)

[openshift-ci-robot]

@hroyrh: This pull request references Jira Issue OCPBUGS-15235, which is invalid:

• expected the bug to target the "4.13.z" version, but no target version was set
• expected Jira Issue OCPBUGS-15235 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This patch deals with overlooked situation in patch d23f72e, in which irmc_ipmi_succeed flag is added to deal with iRMC firmware's IPMI incompatibility introduced at iRMC firmware version S6 2.00 and later.
That flag is set and updated by irmc power_interface code and rest of iRMC driver code use that flag.

When ipmitool is set as power_interface, that flag is not set nor updated and rest of iRMC driver code fail to handle IPMI incompatibility correctly.

This patch adds logic to check power_interface to
make iRMC driver properly deal with iRMC firmware's IPMI incompatibility even when ipmitool power_interface is used.

Change-Id: Id353c4f5260a7c469779b50ad302f442223df5a0 (cherry picked from commit 27bf209)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@hroyrh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rhjanders]

/lgtm

[hroyrh]

/jira refresh

[openshift-ci-robot]

@hroyrh: This pull request references Jira Issue OCPBUGS-15235, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.z) matches configured target version for branch (4.13.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-13564 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-13564 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
• bug has dependents

Requesting review from QA contact:
/cc @pamoedom

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elfosardo]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, hroyrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [elfosardo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elfosardo]

/hold

[elfosardo]

/unhold

[openshift-ci-robot]

@hroyrh: Jira Issue OCPBUGS-15235: All pull requests linked via external trackers have merged:

• openshift/openstack-ironic#21

Jira Issue OCPBUGS-15235 has been moved to the MODIFIED state.

In response to this:

This patch deals with overlooked situation in patch d23f72e, in which irmc_ipmi_succeed flag is added to deal with iRMC firmware's IPMI incompatibility introduced at iRMC firmware version S6 2.00 and later.
That flag is set and updated by irmc power_interface code and rest of iRMC driver code use that flag.

When ipmitool is set as power_interface, that flag is not set nor updated and rest of iRMC driver code fail to handle IPMI incompatibility correctly.

This patch adds logic to check power_interface to
make iRMC driver properly deal with iRMC firmware's IPMI incompatibility even when ipmitool power_interface is used.

Change-Id: Id353c4f5260a7c469779b50ad302f442223df5a0 (cherry picked from commit 27bf209)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.