Merge https://github.com/openstack/ironic:master (1d0818c) into master #7
Conversation
![ironic-merge-bot[bot]](https://avatars.githubusercontent.com/in/259896?s=60&v=4){kind=small}
The troubleshooting kernel command line option nomodeset unfortunately changes the way framebuffer interactions work with graphics devices which in some cases can result in kernel memory to be used for graphics updates. When this happens on some specific hardware common in rack mount servers with baseboard management controllers, this can cause the memory bus to become locked for a brief time while the graphics update is occuring. This locked memory bus means disk IO can become blocked, and network cards can overflow their buffers resulting in packet loss on top of the latency incurred by the graphics update executing. As such, we've removed the nomodeset option from default usage and added a note describing its removal to the documentation along with a release note. Change-Id: I9084d88c3ec6f13bd64b8707892758fa87dd7f86
Patch Ic8b1d964f7be5784e01c89bfb6c0277ea82eec2d was developed without the autocommit change in place, which should allow Ironic to operate properly with sqlite, in a single process standalone mode. As such, we shouldn't need to keep autocommit turned on, but we may need to put it back if we identify yet another issue, which is entirely possible with major database refactors. Change-Id: Icde231e9db3b7a9f59205505cd51a4064e41d746
Currently, if an attempt is made to fetch MAC address information using OOB inspection on a Redfish-managed node and EthernetInterfaces attribute is missing on the node, inspection fails due to a MissingAttributeError exception being raised by sushy. This change adds catching and handling this exception. Change-Id: I6f16da05e19c7efc966128fdf79f13546f51b5a6
We need to fix the tests first, so this needs to pass https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/882312 Change-Id: I5a9536f24103032059f25f9f69fda354e9e38187
hashring use time.time() to calculate intervals, replace with monotonic so it will not be affected by system time jump. Change-Id: I17569359f4d2c0f2f24ca8b50773c4d210ed8deb
The test, periodically under certian CI race conditions, may be handled as if there was not a change, which breaks the test as it does not save a modified port, it uses the in-flight list of changes to determine the correct path. The challenge is, the list of changes may not reconize there has been a change with the underlying object/db layer. So instead of re-test the library code, we just force the behavior by replacing the method on the object in the test, as the undrelying method being tested is tested as part of the oslo versioned objects code base. Change-Id: Ic8f9b2384ab2f8f76299afce9806fbe93e350f0e
Turns out more than one test was relying upon the object change determination test. Modifies this test to use the same pattern of behavior so we are avoiding racing. Change-Id: I29ee6cab7320d13fcc2eeda27dae08aeb2d98b00
When doing a GET or PUT on an indicator the indicator specified must use `indicator@component` syntax. For example: indicators/led@system or indicators/led-0@chassis Ref: ironic.api.controllers.v1.node.IndicatorAtComponent Change-Id: I6908544b52be88cbddf537c954dd5e097a0d83e6
For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: Ice56ac44161d27ede41fdf53024e62e49c572049
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
/approve |
|
Hi @ironic-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, ironic-merge-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ironic-merge-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
approved
No description provided.