Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress: re-add proxy.Status.HTTPProxy check #135

Merged
merged 1 commit into from Nov 2, 2023

Conversation

EmilienM
Copy link
Member

@EmilienM EmilienM commented Nov 2, 2023

If a cluster is running in a disconnected environment (ie BYON), the LBs
can't be created because right now the tests rely on Floating-IPs, which
is not a resource we can use in a restricted network.

Re-adding the previous condition, aside of the new one to cover both
use-cases.

If a cluster is running in a disconnected environment (ie BYON), the LBs
can't be created because right now the tests rely on Floating-IPs, which
is not a resource we can use in a restricted network.

Re-adding the previous condition, aside of the new one to cover both
use-cases.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 2, 2023
@openshift-ci-robot
Copy link

@EmilienM: This pull request references Jira Issue OCPBUGS-18607, which is invalid:

  • expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.14.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If a cluster is running in a disconnected environment (ie BYON), the LBs
can't be created because right now the tests rely on Floating-IPs, which
is not a resource we can use in a restricted network.

Re-adding the previous condition, aside of the new one to cover both
use-cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM changed the title OCPBUGS-18607: re-add proxy.Status.HTTPProxy check ingress: re-add proxy.Status.HTTPProxy check Nov 2, 2023
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 2, 2023
@openshift-ci-robot
Copy link

@EmilienM: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

If a cluster is running in a disconnected environment (ie BYON), the LBs
can't be created because right now the tests rely on Floating-IPs, which
is not a resource we can use in a restricted network.

Re-adding the previous condition, aside of the new one to cover both
use-cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rlobillo
Copy link
Contributor

rlobillo commented Nov 2, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rlobillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 1fad59b into openshift:main Nov 2, 2023
5 checks passed
@EmilienM EmilienM deleted the egress branch November 2, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants