[release-4.14] OCPBUGS-26000: Fix machineset machine role test #148
Conversation
The test was asserting that all MachineSets must label their machines as workers, which is not valid in a variety of situations. For example, we document the creation of 'infra' nodes, but as this is user-controlled data there are no constraints on what this value might be. We remove this test as there is no useful assertion we can make here. Instead we assert that all machines get the labels from their machineset, which is consistent with the existing machineset machine test.
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-23352 has been cloned as Jira Issue OCPBUGS-26000. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-low
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-26000, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@pierreprinetti: This pull request references Jira Issue OCPBUGS-26000, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@pierreprinetti: This pull request references Jira Issue OCPBUGS-26000, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
openshift-merge-bot
bot
merged commit 16e2dcb
into
openshift:release-4.14
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-26000: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-26000 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is an automated cherry-pick of #147
/assign pierreprinetti