Add pre-created fip testcase #61
Conversation
openshift-merge-robot
added
the
needs-rebase
rlobillo
force-pushed
the
precreated_fip
branch
from
3634f3f
to
40202dc
Compare
openshift-merge-robot
removed
the
needs-rebase
rlobillo
force-pushed
the
precreated_fip
branch
2 times, most recently
from
3837ebe
to
a836a15
Compare
|
/retest |
openshift-merge-robot
added
the
needs-rebase
|
@rlobillo: Overrode contexts on behalf of rlobillo: ci/prow/test-kuryr In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rlobillo
force-pushed
the
precreated_fip
branch
from
a836a15
to
6474225
Compare
openshift-merge-robot
removed
the
needs-rebase
rlobillo
force-pushed
the
precreated_fip
branch
2 times, most recently
from
b76fdec
to
743ce40
Compare
|
/override ci/prow/test-kuryr |
|
@rlobillo: Overrode contexts on behalf of rlobillo: ci/prow/test-kuryr In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| return network.ID, nil | ||
| } | ||
| } else { | ||
| return network.ID, nil |
There was a problem hiding this comment.
You still wants to return if subnet is not accessible?
There was a problem hiding this comment.
Yes, in fact that is the typical case: The external network is created by the openstack admin with --no-share true so the tenant cannot inspect the external subnets. Please refer to kubernetes/cloud-provider-openstack#2014
| @@ -419,3 +478,56 @@ func createTestDeployment(depName string, labels map[string]string, replicas int | |||
| }} | |||
| return testDeployment | |||
| } | |||
|
|
|||
| // GetFloatingNetworkID returns a floating network ID. | |||
| func GetFloatingNetworkID(client *gophercloud.ServiceClient) (string, error) { | |||
There was a problem hiding this comment.
So this mimics how the cloud provider gets the ID of the floating IP network? What happens if it's forced to be something else in the configuration? IMO test should check the config too. Or you should pass your own network as an annotation when creating the service, but then it's probably not guaranteed the connectivity will always work if you choose something inappropriate for the setup.
There was a problem hiding this comment.
Exactly, these functions are highly inspired by https://github.com/openshift/cloud-provider-openstack/blob/master/pkg/util/openstack/network.go#L53
The intention of this test is to validate that user can set a previously created FIP on the svc definition, so CCM does not need to create it at all, and it just makes use of it.
Therefore, what is defined on the cloud-provider-config should be irrelevant in this case.
There was a problem hiding this comment.
@rlobillo: What if there's only one "correct" FIP subnet that can be accessed from where the tests are run and it is set in the config? If autodetection takes incorrect one the connectivity check will fail. I'm just trying to find the corner cases so that when some job with a specific configuration will be run we won't need to debug why this test fails.
There was a problem hiding this comment.
@dulek: OK! the test will use the subnet on cloud-provider-config in case it's configured and, if not, auto-detect. I'm on it.
Covers partially the epic https://issues.redhat.com/browse/OSASINFRA-2753 Test that creates a FIP on openstack and use it for creating an UDP svc type:LoadBalancer that sets on its spec the pre-created FIP. This test will be skipped for Kuryr NetworkType and will run with both amphora and OVN provider.
rlobillo
force-pushed
the
precreated_fip
branch
from
743ce40
to
3c09722
Compare
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@rlobillo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel Looking good! |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/cherry-pick release-4.12 |
|
@rlobillo: new pull request created: #70 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Covers partially the epic https://issues.redhat.com/browse/OSASINFRA-2753
Test that creates a FIP on openstack and uses it for creating an UDP svc type:LoadBalancer that sets on its spec the pre-created FIP.
This test will be skipped for Kuryr NetworkType and will run with both amphora and OVN provider.