Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: UPSTREAM: <carry>: update owners #47

Merged
merged 1 commit into from Mar 27, 2024
Merged

NO-ISSUE: UPSTREAM: <carry>: update owners #47

merged 1 commit into from Mar 27, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Mar 27, 2024

  • Remove alumni from owners
  • Add m1kola to approvers

@m1kola
UPSTREAM: <carry>: update owners
820da40 
* Remove alumni from owners
* Add m1kola to approvers

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola changed the title UPSTREAM: <carry>: update owners NO-ISSUE: UPSTREAM: <carry>: update owners Mar 27, 2024
@openshift-ci-robot
Copy link

@m1kola: This pull request explicitly references no jira issue.

In response to this:

  • Remove alumni from owners
  • Add m1kola to approvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

@m1kola: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rashmigottipati
rashmigottipati approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@kevinrizza
Copy link
Member

/lgtm
/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, m1kola, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ff172fe into openshift:main Mar 27, 2024
8 checks passed
@m1kola m1kola deleted the update_owners branch March 27, 2024 18:19
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-olm-catalogd-container-v4.16.0-202403280418.p0.gff172fe.assembly.stream.el8 for distgit ose-olm-catalogd.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@rashmigottipati rashmigottipati

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@m1kola @openshift-ci-robot @kevinrizza @openshift-bot @rashmigottipati