New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1989600: Registry server RSS and CPU utilization too high during normal operation #147
Conversation
This fixes the result set to contain one row per result Bundle instead of potentially several, which should allow for gRPC result streaming. Signed-off-by: Ben Luddy <bluddy@redhat.com> Upstream-repository: operator-registry Upstream-commit: e7f618928629a3492246e30bceebc0ccd55c4b11
For each bundle in its result, ListBundles has been making three separate database queries -- for properties, dependencies, and plural API names -- via GetApisForEntry in order to populate the bundle fields providedApis and requiredApis. Properties and dependencies are already in hand and can be reused. Setting plural names on the elements of providedApis and requiredApis is pointless because plurals are discarded by the catalog operator at runtime. Signed-off-by: Ben Luddy <bluddy@redhat.com> Upstream-repository: operator-registry Upstream-commit: 5364719fc15a53fb6cdc9645ad4b05b778f77346
This commit introduces a change to the registry's ListBundles command so it may stream bundles as they become available. Signed-off-by: Alexander Greene <greene.al1991@gmail.com> Upstream-repository: operator-registry Upstream-commit: 36205150680349edc0c816d0dac8585780e30b6f
…(#725) The "object" and "csvJson" fields of bundles returned from ListBundles is only consumed by the catalog operator in cases where no bundle image reference is present. Signed-off-by: Ben Luddy <bluddy@redhat.com> Upstream-repository: operator-registry Upstream-commit: 6a065947e60f3f2afc1dd3b934cbc802696a1807
Registry pods receive low request volumes and are not latency-sensitive, so there's little downside to advising SQLite to keep its page cache as small as possible. Signed-off-by: Ben Luddy <bluddy@redhat.com> Upstream-repository: operator-registry Upstream-commit: 5fc0f42215d752a43e1fb052a71d37b36b4c57e8
/lgtm |
@benluddy: An error was encountered querying GitHub for users with public email (jiazha@redhat.com) for bug 1989600 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/bugzilla refresh |
@benluddy: This pull request references Bugzilla bug 1989600, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@benluddy: All pull requests linked via external trackers have merged: Bugzilla bug 1989600 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ft#147) Signed-off-by: Ankita Thomas <ankithom@redhat.com> Upstream-repository: api Upstream-commit: 6db422fda8df2f7872a493dd696152eaf2e8a4da
No description provided.