Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1989600: Registry server RSS and CPU utilization too high during normal operation #147

Merged
merged 5 commits into from Aug 4, 2021

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Aug 3, 2021

No description provided.

benluddy and others added 5 commits August 3, 2021 10:27
This fixes the result set to contain one row per result Bundle instead
of potentially several, which should allow for gRPC result streaming.

Signed-off-by: Ben Luddy <bluddy@redhat.com>
Upstream-repository: operator-registry
Upstream-commit: e7f618928629a3492246e30bceebc0ccd55c4b11
For each bundle in its result, ListBundles has been making three
separate database queries -- for properties, dependencies, and plural
API names -- via GetApisForEntry in order to populate the bundle
fields providedApis and requiredApis. Properties and dependencies are
already in hand and can be reused. Setting plural names on the
elements of providedApis and requiredApis is pointless because plurals
are discarded by the catalog operator at runtime.

Signed-off-by: Ben Luddy <bluddy@redhat.com>
Upstream-repository: operator-registry
Upstream-commit: 5364719fc15a53fb6cdc9645ad4b05b778f77346
This commit introduces a change to the registry's ListBundles
command so it may stream bundles as they become available.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 36205150680349edc0c816d0dac8585780e30b6f
…(#725)

The "object" and "csvJson" fields of bundles returned from ListBundles
is only consumed by the catalog operator in cases where no bundle
image reference is present.

Signed-off-by: Ben Luddy <bluddy@redhat.com>
Upstream-repository: operator-registry
Upstream-commit: 6a065947e60f3f2afc1dd3b934cbc802696a1807
Registry pods receive low request volumes and are not
latency-sensitive, so there's little downside to advising SQLite to
keep its page cache as small as possible.

Signed-off-by: Ben Luddy <bluddy@redhat.com>
Upstream-repository: operator-registry
Upstream-commit: 5fc0f42215d752a43e1fb052a71d37b36b4c57e8
@awgreene
Copy link
Contributor

awgreene commented Aug 3, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

@benluddy: An error was encountered querying GitHub for users with public email (jiazha@redhat.com) for bug 1989600 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1989600: Registry server RSS and CPU utilization too high during normal operation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@timflannagan
Copy link
Contributor

/lgtm

@benluddy
Copy link
Contributor Author

benluddy commented Aug 3, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

@benluddy: This pull request references Bugzilla bug 1989600, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 3, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 552292e into openshift:master Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

@benluddy: All pull requests linked via external trackers have merged:

Bugzilla bug 1989600 has been moved to the MODIFIED state.

In response to this:

Bug 1989600: Registry server RSS and CPU utilization too high during normal operation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ankitathomas added a commit to ankitathomas/operator-framework-olm that referenced this pull request Aug 18, 2021
…ft#147)

Signed-off-by: Ankita Thomas <ankithom@redhat.com>

Upstream-repository: api
Upstream-commit: 6db422fda8df2f7872a493dd696152eaf2e8a4da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants