Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1994038: Update kubebuilder installation in the build root dockerfile #174

Conversation

timflannagan
Copy link
Contributor

Update the base.Dockerfile (the dockerfile specified in the build_root
stanza in the o/release ci-operator configuration) and ensure that
kubebuilder can be successfully installed.

The following errors were identified in recent e2e runs:

$ curl -L "https://go.kubebuilder.io/dl/${KUBEBUILDER_RELEASE}/${OS}/${ARCH}" | tar -xz -C /tmp/
...
Complete!
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    68  100    68    0     0    230      0 --:--:-- --:--:-- --:--:--   230

100 20604  100 20604    0     0  60958      0 --:--:-- --:--:-- --:--:-- 60958
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

When inspecting locally, the output file was HTML-based:

$ file ./kubebuilder
file kubebuilder
kubebuilder: HTML document, UTF-8 Unicode text, with very long lines

Replace the kubebuilder release URL to use the github release download
link, instead of the https://go.kubebuilder.io/dl domain.

Update the base.Dockerfile (the dockerfile specified in the `build_root`
stanza in the o/release ci-operator configuration) and ensure that
kubebuilder can be successfully installed.

The following errors were identified in recent e2e runs:

```bash
$ curl -L "https://go.kubebuilder.io/dl/${KUBEBUILDER_RELEASE}/${OS}/${ARCH}" | tar -xz -C /tmp/
...
Complete!
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    68  100    68    0     0    230      0 --:--:-- --:--:-- --:--:--   230

100 20604  100 20604    0     0  60958      0 --:--:-- --:--:-- --:--:-- 60958
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
```

When inspecting locally, the output file was HTML-based:

```bash
$ file ./kubebuilder
file kubebuilder
kubebuilder: HTML document, UTF-8 Unicode text, with very long lines
```

Replace the kubebuilder release URL to use the github release download
link, instead of the https://go.kubebuilder.io/dl domain.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

@timflannagan: This pull request references Bugzilla bug 1994038, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1992677 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1992677 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 1994038: Update kubebuilder installation in the build root dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2021
@sdodson
Copy link
Member

sdodson commented Aug 23, 2021

/lgtm
(assuming the bot pays attention to me)
I'll override cherry-pick-approved to pick up this test fix.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 23, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@sdodson
Copy link
Member

sdodson commented Aug 23, 2021

Backports #172

@timflannagan
Copy link
Contributor Author

Changes made to the build root dockerfile aren't tested in CI as we use the default configuration behavior where CI only builds the current HEAD version: https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image.

/override ci/prow/images
/override ci/prow/unit-api
/override ci/prow/unit-registry
/override ci/prow/unit-olm
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-aws-console-olm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-aws-console-olm, ci/prow/e2e-aws-olm, ci/prow/e2e-gcp, ci/prow/e2e-upgrade, ci/prow/images, ci/prow/unit-api, ci/prow/unit-olm, ci/prow/unit-registry

In response to this:

Changes made to the build root dockerfile aren't tested in CI as we use the default configuration behavior where CI only builds the current HEAD version: https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image.

/override ci/prow/images
/override ci/prow/unit-api
/override ci/prow/unit-registry
/override ci/prow/unit-olm
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-aws-console-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor Author

/override ci/prow/images
/override ci/prow/unit-api
/override ci/prow/unit-registry
/override ci/prow/unit-olm
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-aws-console-olm

1 similar comment
@timflannagan
Copy link
Contributor Author

/override ci/prow/images
/override ci/prow/unit-api
/override ci/prow/unit-registry
/override ci/prow/unit-olm
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-aws-console-olm

@timflannagan
Copy link
Contributor Author

/override ci/prow/verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-aws-console-olm, ci/prow/e2e-aws-olm, ci/prow/e2e-gcp, ci/prow/e2e-upgrade, ci/prow/images, ci/prow/unit-api, ci/prow/unit-olm, ci/prow/unit-registry

In response to this:

/override ci/prow/images
/override ci/prow/unit-api
/override ci/prow/unit-registry
/override ci/prow/unit-olm
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-aws-console-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-aws-console-olm, ci/prow/e2e-aws-olm, ci/prow/e2e-gcp, ci/prow/e2e-upgrade, ci/prow/images, ci/prow/unit-api, ci/prow/unit-olm, ci/prow/unit-registry

In response to this:

/override ci/prow/images
/override ci/prow/unit-api
/override ci/prow/unit-registry
/override ci/prow/unit-olm
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-aws-console-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit f936939 into openshift:release-4.8 Aug 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

@timflannagan: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1994038 has not been moved to the MODIFIED state.

In response to this:

Bug 1994038: Update kubebuilder installation in the build root dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan timflannagan deleted the release-4.8-fix-build-root-image branch August 23, 2021 17:31
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021
* fix: clarifies message error regards service account

* apply suggestions

Upstream-repository: api
Upstream-commit: f579141ce61d8bb7c4dc7c06169bc436ac4b9703
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021
* fix: clarifies message error regards service account

* apply suggestions

Upstream-repository: api
Upstream-commit: f579141ce61d8bb7c4dc7c06169bc436ac4b9703
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
* fix: clarifies message error regards service account

* apply suggestions

Upstream-repository: api
Upstream-commit: f579141ce61d8bb7c4dc7c06169bc436ac4b9703
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
* fix: clarifies message error regards service account

* apply suggestions

Upstream-repository: api
Upstream-commit: f579141ce61d8bb7c4dc7c06169bc436ac4b9703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants