Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1945584: Remove overrides for GOOS and GOARCH in cpb Makefile recipe. #35

Merged
merged 1 commit into from Apr 6, 2021
Merged

Bug 1945584: Remove overrides for GOOS and GOARCH in cpb Makefile recipe. #35

merged 1 commit into from Apr 6, 2021

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Apr 5, 2021

This appears to have been a mistake during the downstream migration
and results in broken bundle unpack jobs on non-x86 hosts.

@benluddy
Remove overrides for GOOS and GOARCH in cpb Makefile recipe.
b4f844f 
This appears to have been a mistake during the downstream migration
and results in broken bundle unpack jobs on non-x86 hosts.
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2021
@benluddy benluddy changed the title Remove overrides for GOOS and GOARCH in cpb Makefile recipe. Bug 1945584: Remove overrides for GOOS and GOARCH in cpb Makefile recipe. Apr 5, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 5, 2021
@openshift-ci-robot
Copy link

@benluddy: This pull request references Bugzilla bug 1945584, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 1945584: Remove overrides for GOOS and GOARCH in cpb Makefile recipe.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor

Adding a hold so this PR doesn't automatically merge (need to update the existing tests so they're not optional anymore) and we get some CI feedback.

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2021
@timflannagan
Copy link
Contributor

Looks good to go.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2021
@openshift-merge-robot openshift-merge-robot merged commit 669c5c6 into openshift:master Apr 6, 2021
@openshift-ci-robot
Copy link

@benluddy: All pull requests linked via external trackers have merged:

Bugzilla bug 1945584 has been moved to the MODIFIED state.

In response to this:

Bug 1945584: Remove overrides for GOOS and GOARCH in cpb Makefile recipe.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Apr 6, 2021
@openshift-merge-robot @ankitathomas
Merge pull request openshift#35 from mhrivnak/typos
eeb5b81 
fixes typos in README.md

(upstream operator-registry commit: 2275b6391383b687165b5588a7628aebf7840d74)
ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Apr 6, 2021
@kevinrizza @ankitathomas
Merge pull request openshift#35 from kevinrizza/remove-registry-dep
4ef3c41 
Remove registry dependency

(cherry picked from commit 197407cd70e8ddfef85d21216085ed52fbb4bb2d)
ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Apr 6, 2021
@kevinrizza @ankitathomas
Merge pull request openshift#35 from kevinrizza/remove-registry-dep
988fd46 
Remove registry dependency

(upstream api commit: 197407cd70e8ddfef85d21216085ed52fbb4bb2d)
ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Apr 9, 2021
@kevinrizza @ankitathomas
Merge pull request openshift#35 from kevinrizza/remove-registry-dep
65a4f26 
Remove registry dependency

(upstream api commit: 197407cd70e8ddfef85d21216085ed52fbb4bb2d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@timflannagan timflannagan Awaiting requested review from timflannagan

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benluddy @openshift-ci-robot @timflannagan @openshift-merge-robot