OCPBUGS-7904: Cleanup conversion webhooks when an operator is uninstalled

[awgreene]

Problem: When uninstalling a CSV, OLM has always avoided deleting the associated CRD as all CRs on cluster are subsequently deleted, possibly resulting in user dataloss.

OLM supports defining conversion webhooks within the CSV. On cluster, conversion webhooks are defined with a CRD and point to a service that handles conversion. If the service is unable to fulfill the request, all requests against the CRs associated with the CRD will fail.

When uninstalling a CSV, OLM does not remove the conversion webhook from the CRD, meaning that all requests against the CRs associated with the CRD will fail, resulting in at least two concerns:

1. OLM is unable to subsequently reinstall the operator. When installing a CSV, if the CRD already exists and instances of CRs exist as well, OLM performs a series of checks which ensure that none of the CRs are invalidated against the new schema. The existing CRD's conversion webhooks points to a non-existant service, causing the check to fail and preventing installs.
2. Broken conversion webhooks causes kubernete's garbage collection to fail.

Solution: When a CSV is deleted, if no CSV exists that is replacing it, set the CRD's conversion strategy to None.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-commit: 94374983d448c56d031f0493b84b6dce37b84741
Upstream-repository: operator-lifecycle-manager

[awgreene]

/jira refresh

[openshift-ci]

@awgreene: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-7904: Cleanup conversion webhooks when an operator is uninstalled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[awgreene]

/jira refresh

[openshift-ci-robot]

@awgreene: This pull request references Jira Issue OCPBUGS-7904, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.10.z) matches configured target version for branch (4.10.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-1556 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-1556 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
• bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@awgreene: This pull request references Jira Issue OCPBUGS-7904, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.10.z) matches configured target version for branch (4.10.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-1556 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-1556 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
• bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Problem: When uninstalling a CSV, OLM has always avoided deleting the associated CRD as all CRs on cluster are subsequently deleted, possibly resulting in user dataloss.

OLM supports defining conversion webhooks within the CSV. On cluster, conversion webhooks are defined with a CRD and point to a service that handles conversion. If the service is unable to fulfill the request, all requests against the CRs associated with the CRD will fail.

When uninstalling a CSV, OLM does not remove the conversion webhook from the CRD, meaning that all requests against the CRs associated with the CRD will fail, resulting in at least two concerns:

1. OLM is unable to subsequently reinstall the operator. When installing a CSV, if the CRD already exists and instances of CRs exist as well, OLM performs a series of checks which ensure that none of the CRs are invalidated against the new schema. The existing CRD's conversion webhooks points to a non-existant service, causing the check to fail and preventing installs.
2. Broken conversion webhooks causes kubernete's garbage collection to fail.

Solution: When a CSV is deleted, if no CSV exists that is replacing it, set the CRD's conversion strategy to None.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-commit: 94374983d448c56d031f0493b84b6dce37b84741
Upstream-repository: operator-lifecycle-manager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@awgreene: This pull request references Jira Issue OCPBUGS-7904, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.10.z) matches configured target version for branch (4.10.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-1556 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-1556 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
• bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@awgreene: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.10] OCPBUGS-7904: Cleanup conversion webhooks when an operator is uninstalled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[awgreene]

/jira refresh

[openshift-ci-robot]

@awgreene: This pull request references Jira Issue OCPBUGS-7904, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.10.z) matches configured target version for branch (4.10.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-1556 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-1556 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
• bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[awgreene]

/retest

[kuiwang02]

/jira refresh

[kuiwang02]

/label cherry-pick-approved

[kuiwang02]

/label qe-approved

[perdasilva]

/retest

[grokspawn]

/retest

[awgreene]

/retest

[awgreene]

/retest

[awgreene]

/retest

[ankitathomas]

/test unit-psm

[awgreene]

/retest

[awgreene]

/retest

[awgreene]

/retest

[awgreene]

/retest

[ankitathomas]

/retest

[ankitathomas]

/retest

[ankitathomas]

/retest

[ankitathomas]

/retest

[m1kola]

/retest

[ankitathomas]

/retest

[ankitathomas]

/retest

[perdasilva]

/retest

[perdasilva]

/retest

[awgreene]

/retest

[awgreene]

/retest

[m1kola]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[perdasilva]

/label backport-risk-assessed

[openshift-ci]

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@awgreene: Jira Issue OCPBUGS-7904: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#458

Jira Issue OCPBUGS-7904 has been moved to the MODIFIED state.

In response to this:

Problem: When uninstalling a CSV, OLM has always avoided deleting the associated CRD as all CRs on cluster are subsequently deleted, possibly resulting in user dataloss.

OLM supports defining conversion webhooks within the CSV. On cluster, conversion webhooks are defined with a CRD and point to a service that handles conversion. If the service is unable to fulfill the request, all requests against the CRs associated with the CRD will fail.

When uninstalling a CSV, OLM does not remove the conversion webhook from the CRD, meaning that all requests against the CRs associated with the CRD will fail, resulting in at least two concerns:

1. OLM is unable to subsequently reinstall the operator. When installing a CSV, if the CRD already exists and instances of CRs exist as well, OLM performs a series of checks which ensure that none of the CRs are invalidated against the new schema. The existing CRD's conversion webhooks points to a non-existant service, causing the check to fail and preventing installs.
2. Broken conversion webhooks causes kubernete's garbage collection to fail.

Solution: When a CSV is deleted, if no CSV exists that is replacing it, set the CRD's conversion strategy to None.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-commit: 94374983d448c56d031f0493b84b6dce37b84741
Upstream-repository: operator-lifecycle-manager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.