Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15737: Re-enable psa plugin #500

Merged

Conversation

perdasilva
Copy link
Contributor

Upstream PSA changes were introduced in Kubernetes 1.25 (OpenShift 4.12). Downstream OLM has a plug-in that integrates with the security team's Cluster-Policy-Constroller that helps smooth out the transition and helps avoid stuck workloads for our customers. We had to disable the plug-in in 4.12. It's not ready to be re-enabled.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@perdasilva perdasilva changed the title Re-enable psa plugin OCPBUGS-15737: Re-enable psa plugin Jul 3, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 3, 2023
@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-15737, which is invalid:

  • expected the bug to target the "4.12.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-15737 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Upstream PSA changes were introduced in Kubernetes 1.25 (OpenShift 4.12). Downstream OLM has a plug-in that integrates with the security team's Cluster-Policy-Constroller that helps smooth out the transition and helps avoid stuck workloads for our customers. We had to disable the plug-in in 4.12. It's not ready to be re-enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 3, 2023
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
Copy link
Contributor Author

/test unit-olm

@perdasilva
Copy link
Contributor Author

/override ci/prow/verify

this stage fails because there are changes to the staging directory. These changes affect downstream files only. ok to override.

@perdasilva
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/verify

In response to this:

/override ci/prow/verify

this stage fails because there are changes to the staging directory. These changes affect downstream files only. ok to override.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kuiwang02
Copy link

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Jul 4, 2023
@perdasilva
Copy link
Contributor Author

/override verify

Changes here are in downstream only files in the staging (which normally is closed for changes outside of upstream commits). This is one of the rare cases where we need to make changes to downstream only behavior that must exist in the olm src tree in the staging directory.

@perdasilva
Copy link
Contributor Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

@perdasilva: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • verify

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-gcp-console-olm
  • ci/prow/e2e-gcp-olm
  • ci/prow/e2e-gcp-olm-flaky
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-upgrade
  • ci/prow/images
  • ci/prow/unit-api
  • ci/prow/unit-olm
  • ci/prow/unit-psm
  • ci/prow/unit-registry
  • ci/prow/verify
  • pull-ci-openshift-operator-framework-olm-master-e2e-gcp-console-olm
  • pull-ci-openshift-operator-framework-olm-master-e2e-gcp-olm
  • pull-ci-openshift-operator-framework-olm-master-e2e-gcp-olm-flaky
  • pull-ci-openshift-operator-framework-olm-master-e2e-gcp-ovn
  • pull-ci-openshift-operator-framework-olm-master-e2e-upgrade
  • pull-ci-openshift-operator-framework-olm-master-images
  • pull-ci-openshift-operator-framework-olm-master-unit-api
  • pull-ci-openshift-operator-framework-olm-master-unit-olm
  • pull-ci-openshift-operator-framework-olm-master-unit-psm
  • pull-ci-openshift-operator-framework-olm-master-unit-registry
  • pull-ci-openshift-operator-framework-olm-master-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override verify

Changes here are in downstream only files in the staging (which normally is closed for changes outside of upstream commits). This is one of the rare cases where we need to make changes to downstream only behavior that must exist in the olm src tree in the staging directory.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor Author

/override ci/prow/verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

@perdasilva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 1069c89 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@perdasilva
Copy link
Contributor Author

/jira-refresh

@perdasilva
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-15737, which is invalid:

  • expected Jira Issue OCPBUGS-15737 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-15737, which is invalid:

  • expected Jira Issue OCPBUGS-15737 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-15737, which is invalid:

  • expected Jira Issue OCPBUGS-15737 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 5, 2023
@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-15737, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-15808 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-15808 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from kuiwang02 July 5, 2023 13:54
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7e5d57a into openshift:release-4.12 Jul 5, 2023
12 checks passed
@openshift-ci-robot
Copy link

@perdasilva: Jira Issue OCPBUGS-15737: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15737 has been moved to the MODIFIED state.

In response to this:

Upstream PSA changes were introduced in Kubernetes 1.25 (OpenShift 4.12). Downstream OLM has a plug-in that integrates with the security team's Cluster-Policy-Constroller that helps smooth out the transition and helps avoid stuck workloads for our customers. We had to disable the plug-in in 4.12. It's not ready to be re-enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants