Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] OCPBUGS-16703: Set GO_COMPLIANCE_EXCLUDE to match Makefile #524

Merged
merged 1 commit into from
Jul 24, 2023
Merged

[release-4.7] OCPBUGS-16703: Set GO_COMPLIANCE_EXCLUDE to match Makefile #524

merged 1 commit into from
Jul 24, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #523

/assign joepvd

@joepvd
Set GO_COMPLIANCE_EXCLUDE to match Makefile
6d8dd93 
openshift#516 overrode
the tweak in
openshift-eng/ocp-build-data#3174. This should
set the record straight.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 24, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-16682 has been cloned as Jira Issue OCPBUGS-16703. Will retitle bug to link to clone.
/retitle [release-4.7] OCPBUGS-16703: Set GO_COMPLIANCE_EXCLUDE to match Makefile

In response to this:

This is an automated cherry-pick of #523

/assign joepvd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] OCPBUGS-16682: Set GO_COMPLIANCE_EXCLUDE to match Makefile [release-4.7] OCPBUGS-16703: Set GO_COMPLIANCE_EXCLUDE to match Makefile Jul 24, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 24, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-16703, which is invalid:

  • expected dependent Jira Issue OCPBUGS-16682 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-16682 to target a version in 4.8.0, 4.8.z, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #523

/assign joepvd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jupierce jupierce merged commit c1f9b30 into openshift:release-4.7 Jul 24, 2023
1 check was pending
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-16703: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16703 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #523

/assign joepvd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joepvd joepvd

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @joepvd @jupierce