Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-15067: Bump Masterminds/vcs to 1.13.3 #528

Merged
merged 1 commit into from Sep 8, 2023
Merged

OCPBUGS-15067: Bump Masterminds/vcs to 1.13.3 #528

merged 1 commit into from Sep 8, 2023

Conversation

ankitathomas
Copy link
Contributor

@ankitathomas ankitathomas commented Jul 31, 2023 •
edited

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
@ankitathomas ankitathomas changed the title [WIP] Bump kube to 1.23 Bump kube to 1.23 Sep 6, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2023
@ankitathomas ankitathomas force-pushed the kube-bump branch 2 times, most recently from 5728a92 to f5bda89 Compare September 6, 2023 16:37
@ankitathomas ankitathomas mentioned this pull request Sep 6, 2023
Closed
@ankitathomas ankitathomas force-pushed the kube-bump branch 2 times, most recently from d8eaaec to 835d20f Compare September 6, 2023 17:36
@ankitathomas ankitathomas changed the title Bump kube to 1.23 Bump Masterminds/vcs to 1.13.3 Sep 7, 2023
@awgreene
Copy link
Contributor

awgreene commented Sep 7, 2023

/test unit-olm

@awgreene
Copy link
Contributor

awgreene commented Sep 7, 2023

/retitle OCPBUGS-15067: Bump Masterminds/vcs to 1.13.3

@openshift-ci openshift-ci bot changed the title Bump Masterminds/vcs to 1.13.3 OCPBUGS-15067: Bump Masterminds/vcs to 1.13.3 Sep 7, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 7, 2023
@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-15067, which is invalid:

  • expected Jira Issue OCPBUGS-15067 to depend on a bug targeting a version in 4.11.0, 4.11.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes CVE-2022-21235

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Contributor

awgreene commented Sep 7, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 7, 2023
@awgreene
Copy link
Contributor

awgreene commented Sep 7, 2023

/retest

@grokspawn
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 8, 2023
@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-15067, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18688 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-18688 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2023

@ankitathomas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kuiwang02
Copy link

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Sep 8, 2023
@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 73c6f85 into openshift:release-4.10 Sep 8, 2023
11 checks passed
@openshift-ci-robot
Copy link

@ankitathomas: Jira Issue OCPBUGS-15067: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15067 has been moved to the MODIFIED state.

In response to this:

Fixes CVE-2022-21235

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.10.0-0.nightly-2023-09-09-020435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

Assignees

@bandrade bandrade

@jianzhangbjz jianzhangbjz

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

@grokspawn grokspawn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet