Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the manifests generation #533

Merged
merged 2 commits into from Aug 7, 2023
Merged

fix the manifests generation #533

merged 2 commits into from Aug 7, 2023

Conversation

stevekuznetsov
Copy link
Contributor

manifests: use the CVO-replaced placeholder for version

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

makefile: verify that we use the CVO-based placeholder

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

@stevekuznetsov
manifests: use the CVO-replaced placeholder for version
7fedf7f 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
makefile: verify that we use the CVO-based placeholder
1e0092b 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
awgreene
awgreene approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 7, 2023
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 7, 2023
Merged
@tmshort
Copy link
Contributor

tmshort commented Aug 7, 2023

Is there an issue that this is a regression in version numbering? Does it matter?
Otherwise, looks fine.

tmshort
tmshort approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
So, it shouldn't be considered a regression

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, stevekuznetsov, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3e56c4b into openshift:master Aug 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgreene awgreene awgreene approved these changes

@tmshort tmshort tmshort approved these changes

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@awgreene awgreene

@tmshort tmshort

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stevekuznetsov @tmshort @awgreene @openshift-merge-robot