New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPRUN-3022: Add support for make verify to sync script #537
Conversation
This updates the sync script to use the same targets as "make verify" This minimizes the repetative nature of calling "make verify", and avoids the incorrect update of csv.yaml by "make manifests" Also prefix the Makefile "echo" commands with an @ Signed-off-by: Todd Short <todd.short@me.com>
@tmshort: This pull request references OPRUN-3022 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@tmshort: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, grokspawn, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This updates the sync script to use the same targets as "make verify" This minimizes the repetative nature of calling "make verify", and avoids the incorrect update of csv.yaml by "make manifests"
Also prefix the Makefile "echo" commands with an @