Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPRUN-3022: Add support for make verify to sync script #537

Merged
merged 1 commit into from Aug 14, 2023

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 10, 2023

This updates the sync script to use the same targets as "make verify" This minimizes the repetative nature of calling "make verify", and avoids the incorrect update of csv.yaml by "make manifests"

Also prefix the Makefile "echo" commands with an @

This updates the sync script to use the same targets as "make verify"
This minimizes the repetative nature of calling "make verify", and
avoids the incorrect update of csv.yaml by "make manifests"

Also prefix the Makefile "echo" commands with an @

Signed-off-by: Todd Short <todd.short@me.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 10, 2023

@tmshort: This pull request references OPRUN-3022 which is a valid jira issue.

In response to this:

This updates the sync script to use the same targets as "make verify" This minimizes the repetative nature of calling "make verify", and avoids the incorrect update of csv.yaml by "make manifests"

Also prefix the Makefile "echo" commands with an @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@tmshort
Copy link
Contributor Author

tmshort commented Aug 11, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 32f1cf3 into openshift:master Aug 14, 2023
12 checks passed
@tmshort tmshort deleted the verify branch August 14, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants