Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17157: manifests: add $GOMEMLIMIT to PSM #551

Merged
merged 2 commits into from Sep 26, 2023
Merged

OCPBUGS-17157: manifests: add $GOMEMLIMIT to PSM #551

merged 2 commits into from Sep 26, 2023

Conversation

stevekuznetsov
Copy link
Contributor

This component has inuse_space around 3MiB in the wild.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 17, 2023
@openshift-ci-robot
Copy link

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This component has inuse_space around 3MiB in the wild.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov stevekuznetsov mentioned this pull request Aug 17, 2023
Closed
38 tasks
@stevekuznetsov
Copy link
Contributor Author

/retest

@stevekuznetsov stevekuznetsov force-pushed the skuznets/psm-gomemlimit branch 2 times, most recently from 34de064 to e04cfc0 Compare August 21, 2023 14:43
@stevekuznetsov
Copy link
Contributor Author

Screenshot from 2023-08-21 09-32-41

We are in likely the best state we can be, unless I figure out what is going on with GCSys ...

@stevekuznetsov
Copy link
Contributor Author

/retest

3 similar comments
@stevekuznetsov
Copy link
Contributor Author

/retest

@stevekuznetsov
Copy link
Contributor Author

/retest

@stevekuznetsov
Copy link
Contributor Author

/retest

awgreene
awgreene approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 22, 2023
tmshort
tmshort approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tmshort
Copy link
Contributor

tmshort commented Aug 22, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, stevekuznetsov, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort
Copy link
Contributor

tmshort commented Aug 22, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f2de7eb and 2 for PR HEAD e04cfc0 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f8d481f and 1 for PR HEAD e04cfc0 in total

@perdasilva
Copy link
Contributor

/retest

2 similar comments
@stevekuznetsov
Copy link
Contributor Author

/retest

@perdasilva
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 8, 2023
@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Jira Issue OCPBUGS-17157, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
manifests: add $GOMEMLIMIT to PSM
be56667 
This component has inuse_space around 3MiB in the wild.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
package-server-manager: add a PodMonitor, expose metrics
592327a 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@stevekuznetsov
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 8, 2023
@openshift-ci-robot
Copy link

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 8, 2023
@tmshort
Copy link
Contributor

tmshort commented Sep 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@stevekuznetsov
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d4348fd and 2 for PR HEAD 592327a in total

@stevekuznetsov
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ab674aa and 1 for PR HEAD 592327a in total

@perdasilva
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 32213b1 and 0 for PR HEAD 592327a in total

@openshift-ci-robot
Copy link

/hold

Revision 592327a was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2023
@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Sep 26, 2023 •
edited

/retest

install failed

@stevekuznetsov
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 417a2be and 2 for PR HEAD 592327a in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e2338dc into openshift:master Sep 26, 2023
12 checks passed
@openshift-ci-robot
Copy link

@stevekuznetsov: Jira Issue OCPBUGS-17157: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-17157 has not been moved to the MODIFIED state.

In response to this:

This component has inuse_space around 3MiB in the wild.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgreene awgreene awgreene approved these changes

@tmshort tmshort tmshort approved these changes

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@perdasilva perdasilva

@awgreene awgreene

@tmshort tmshort

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@stevekuznetsov @openshift-ci-robot @tmshort @perdasilva @openshift-bot @awgreene @openshift-merge-robot