New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPRUN-1873: scripts/bumper: allow fetching using https #561
OPRUN-1873: scripts/bumper: allow fetching using https #561
Conversation
@stevekuznetsov: This pull request references OPRUN-1873 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
In a container, trying to fetch using git over ssh goes south super quickly. In other contexts we always fetch using https to make our lives easier. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
d54b806
to
33805c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/retest |
1 similar comment
/retest |
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
33805c6
to
9fee111
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, perdasilva, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@stevekuznetsov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
In a container, trying to fetch using git over ssh goes south super quickly. In other contexts we always fetch using https to make our lives easier.