Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPRUN-1873: scripts/bumper: allow fetching using https #561

Conversation

stevekuznetsov
Copy link
Contributor

In a container, trying to fetch using git over ssh goes south super quickly. In other contexts we always fetch using https to make our lives easier.

@stevekuznetsov stevekuznetsov changed the title scripts/bumper: allow fetching using https OPRUN-1873: scripts/bumper: allow fetching using https Sep 9, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 9, 2023

@stevekuznetsov: This pull request references OPRUN-1873 which is a valid jira issue.

In response to this:

In a container, trying to fetch using git over ssh goes south super quickly. In other contexts we always fetch using https to make our lives easier.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link
Contributor Author

/retest

In a container, trying to fetch using git over ssh goes south super
quickly. In other contexts we always fetch using https to make our lives
easier.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2023
@stevekuznetsov
Copy link
Contributor Author

/retest

1 similar comment
@stevekuznetsov
Copy link
Contributor Author

/retest

scripts/bumper/main.go Outdated Show resolved Hide resolved
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@ncdc ncdc added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Sep 11, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, perdasilva, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6799db7 and 2 for PR HEAD 9fee111 in total

@stevekuznetsov
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d4348fd into openshift:master Sep 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants