Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync script: handle multi commit merges #578

Merged
merged 1 commit into from Oct 11, 2023

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Oct 9, 2023

Fix the sync script to handle commits in a single merge.
The sorting doesn't work as the commit time is all the same, and the next sortable field is the headline.
The commit time is the same, but the authorship time for each commit might be different or out of order.
Add an ordinal to the list of commits from each branch. This is used to sort commits (in original order) with the same commit time.

This is for the bash-based sync scripts.

Signed-off-by: Todd Short <todd.short@me.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@tmshort
Copy link
Contributor Author

tmshort commented Oct 9, 2023

This modifies no OLM code; so everything ought to pass.

@tmshort
Copy link
Contributor Author

tmshort commented Oct 9, 2023

/retest

@grokspawn
Copy link
Contributor

/label docs-approved
/label px-approved
/label qe-approved

downstream-only sync infrastructure changes only

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Oct 11, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 586ee40 and 2 for PR HEAD 0b8b027 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit e98b8f0 into openshift:master Oct 11, 2023
12 checks passed
@tmshort tmshort deleted the sync-script branch October 12, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants