Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22134: [release-4.14] Bump golang.org/x/net to v0.17.0 #587

Merged
merged 3 commits into from Oct 20, 2023

Conversation

awgreene
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@tmshort
Copy link
Contributor

tmshort commented Oct 16, 2023

Is this basically a cherry-pick of #585 ?

dependabot bot and others added 3 commits October 16, 2023 11:48
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.10.0 to 0.17.0.
- [Commits](golang/net@v0.10.0...v0.17.0)

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1ca6d9e799cd7da2bc8da287b310da76846efeb2

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 89019fd72c3272b4449c14ce006f579edb83bb98
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.10.0 to 0.17.0.
- [Commits](golang/net@v0.10.0...v0.17.0)

Upstream-repository: api
Upstream-commit: d52e6b24617a980e471dbfde1ec1780de9d23f35

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@awgreene
Copy link
Contributor Author

@tmshort yes, manually created as the associated bugs were created upfront by prod sec.

@tmshort
Copy link
Contributor

tmshort commented Oct 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@tmshort
Copy link
Contributor

tmshort commented Oct 17, 2023

/retest

@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@awgreene awgreene changed the title 4 14 golang x net bump [Release-4.14] Bump golang.org/x/net to v0.17.0 Oct 17, 2023
@awgreene awgreene changed the title [Release-4.14] Bump golang.org/x/net to v0.17.0 [release-4.14] Bump golang.org/x/net to v0.17.0 Oct 17, 2023
@tmshort
Copy link
Contributor

tmshort commented Oct 17, 2023

/retest

1 similar comment
@tmshort
Copy link
Contributor

tmshort commented Oct 18, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oceanc80
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 19, 2023
@oceanc80
Copy link
Contributor

/retitle OCPBUGS-22134: [release-4.14] Bump golang.org/x/net to v0.17.0

@openshift-ci openshift-ci bot changed the title [release-4.14] Bump golang.org/x/net to v0.17.0 OCPBUGS-22134: [release-4.14] Bump golang.org/x/net to v0.17.0 Oct 19, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 19, 2023
@openshift-ci-robot
Copy link

@awgreene: This pull request references Jira Issue OCPBUGS-22134, which is invalid:

  • expected Jira Issue OCPBUGS-22134 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 19, 2023
@bandrade
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 19, 2023
@tmshort
Copy link
Contributor

tmshort commented Oct 20, 2023

/jira refresh

@openshift-ci-robot
Copy link

@tmshort: This pull request references Jira Issue OCPBUGS-22134, which is invalid:

  • expected dependent Jira Issue OCPBUGS-22135 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmshort
Copy link
Contributor

tmshort commented Oct 20, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 20, 2023
@openshift-ci-robot
Copy link

@tmshort: This pull request references Jira Issue OCPBUGS-22134, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-22135 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-22135 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from kuiwang02 October 20, 2023 08:52
@tmshort
Copy link
Contributor

tmshort commented Oct 20, 2023

@joelanford @ncdc ? This needs a (staff-eng-approved) label

@ncdc ncdc added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, ncdc, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit f515d1c into openshift:release-4.14 Oct 20, 2023
12 checks passed
@openshift-ci-robot
Copy link

@awgreene: Jira Issue OCPBUGS-22134: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22134 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet