Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-27314: Don't sync namespaces that have no subscriptions #675

Merged

Conversation

ankitathomas
Copy link
Contributor

Problem: The catalog operator is logging many errors regarding missing operator groups in namespaces that have no operators installed.

Solution: If a namespace has no subscriptions in it, do not check if an operator group is present in the namespace.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 2625ded47cc8260b4a620fd45c2d440bb864413f

Problem: The catalog operator is logging many errors regarding missing
operator groups in namespaces that have no operators installed.

Solution: If a namespace has no subscriptions in it, do not check if an
operator group is present in the namespace.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 2625ded47cc8260b4a620fd45c2d440bb864413f
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 26, 2024
@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-25330, which is invalid:

  • expected the bug to target either version "4.14." or "openshift-4.14.", but it targets "4.15" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-25330 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Problem: The catalog operator is logging many errors regarding missing operator groups in namespaces that have no operators installed.

Solution: If a namespace has no subscriptions in it, do not check if an operator group is present in the namespace.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 2625ded47cc8260b4a620fd45c2d440bb864413f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 26, 2024
@ankitathomas ankitathomas changed the title [release-4.14] OCPBUGS-25330: Don't sync namespaces that have no subscriptions [release-4.14] OCPBUGS-27314: Don't sync namespaces that have no subscriptions Jan 26, 2024
@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-27314, which is invalid:

  • expected Jira Issue OCPBUGS-27314 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Problem: The catalog operator is logging many errors regarding missing operator groups in namespaces that have no operators installed.

Solution: If a namespace has no subscriptions in it, do not check if an operator group is present in the namespace.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 2625ded47cc8260b4a620fd45c2d440bb864413f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@ankitathomas
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-27314, which is invalid:

  • expected Jira Issue OCPBUGS-27314 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ankitathomas
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-27314, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ankitathomas
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-27314, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ankitathomas
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 26, 2024
@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-27314, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-25330 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-25330 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 26, 2024
@Xia-Zhao-rh
Copy link

Test PASS, detail https://issues.redhat.com/browse/OCPBUGS-27314
/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 29, 2024
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

@Xia-Zhao-rh: The label(s) /label qe-approve cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label qe-approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Xia-Zhao-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 29, 2024
@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-27314, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-25330 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-25330 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

Problem: The catalog operator is logging many errors regarding missing operator groups in namespaces that have no operators installed.

Solution: If a namespace has no subscriptions in it, do not check if an operator group is present in the namespace.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 2625ded47cc8260b4a620fd45c2d440bb864413f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Contributor

/lgtm

@perdasilva
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Feb 5, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b831504 and 2 for PR HEAD 1a1264f in total

@Xia-Zhao-rh
Copy link

/retest-required

1 similar comment
@KeenonLee
Copy link
Member

/retest-required

@m1kola
Copy link
Member

m1kola commented Feb 7, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

@ankitathomas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1a03f4b into openshift:release-4.14 Feb 7, 2024
13 checks passed
@openshift-ci-robot
Copy link

@ankitathomas: Jira Issue OCPBUGS-27314: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27314 has been moved to the MODIFIED state.

In response to this:

Problem: The catalog operator is logging many errors regarding missing operator groups in namespaces that have no operators installed.

Solution: If a namespace has no subscriptions in it, do not check if an operator group is present in the namespace.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 2625ded47cc8260b4a620fd45c2d440bb864413f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.14.0-202402071410.p0.g1a03f4b.assembly.stream.el8 for distgit operator-lifecycle-manager.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet