Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: AUTH-481: add PSa labels to openshift namespaces #685

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liouk
Copy link
Member

@liouk liouk commented Feb 7, 2024

  • openshift-operator-lifecycle-manager
  • openshift-operators

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2024

@liouk: This pull request references AUTH-481 which is a valid jira issue.

In response to this:

  • openshift-operator-lifecycle-manager
  • openshift-operators

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk liouk changed the title AUTH-481: add PSa labels to openshift namespaces WIP: AUTH-481: add PSa labels to openshift namespaces Feb 7, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2024
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liouk
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liouk liouk marked this pull request as draft February 7, 2024 12:25
@liouk
Copy link
Member Author

liouk commented Feb 13, 2024

/hold
blocked by https://issues.redhat.com/browse/AUTH-482

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2024
@liouk liouk changed the title WIP: AUTH-481: add PSa labels to openshift namespaces AUTH-481: add PSa labels to openshift namespaces Feb 13, 2024
@liouk liouk marked this pull request as ready for review February 13, 2024 09:24
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2024
@perdasilva
Copy link
Contributor

Hi @liouk ^^ could you please run make manifests, then commit any changes, then run make verify just to double check?

@liouk liouk force-pushed the psa-labels-openshift-namespaces branch from 37322d8 to 25f3f3b Compare April 9, 2024 07:57
@liouk
Copy link
Member Author

liouk commented Apr 9, 2024

Hi @perdasilva, thanks for pointing this out.

I've set the required values in values.yaml, however then running make manifests removes the labels from manifests/0000_50_olm_00-namespace.yaml, even if their values are defined in values.yaml. How can I correctly generate the labels in manifests/0000_50_olm_00-namespace.yaml?

@liouk liouk changed the title AUTH-481: add PSa labels to openshift namespaces WIP: AUTH-481: add PSa labels to openshift namespaces Apr 9, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2024
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

@liouk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 25f3f3b link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants