OPRUN-3221: image just as a cli source for mirror publishing #713
Conversation
openshift-ci
bot
added
the
approved
grokspawn
force-pushed
the
cli-revamp
branch
2 times, most recently
from
8b5eac1
to
0b255bf
Compare
grokspawn
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@grokspawn: This pull request references OPRUN-3221 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
operator-framework-cli.Dockerfile
Outdated
| maintainer="Odin Team <aos-odin@redhat.com>" \ | ||
| summary="Operator Registry runs in a Kubernetes or OpenShift cluster to provide operator catalog data to Operator Lifecycle Manager." | ||
| summary="Operator Lifecycle Manager CLIS are used to manipulate OLM infrastructure, including catalogs of operators." |
There was a problem hiding this comment.
Do we know what the difference is between io.k8s.description and summary?
This suggestion I'm making would make those the same, but not sure if that's actually a good idea.
| summary="Operator Lifecycle Manager CLIS are used to manipulate OLM infrastructure, including catalogs of operators." | |
| summary="This is a non-runnable image containing binary builds of various Operator Framework CLI tools, primarily used to publish binaries to the OpenShift mirror." |
There was a problem hiding this comment.
Not enough samples to have an opinion here.
oc clients doesn't use summary (https://github.com/openshift/oc/blob/master/images/cli-artifacts/Dockerfile.rhel#L31-L33), so on the off-chance that this turns out to be a short-lived image, let's simplify.
Signed-off-by: Jordan <jordan@nimblewidget.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@grokspawn: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
strips out runnable aspects and list of CLIs so this is just a source of OLM/OPM clients for now.