Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: Semver lastedge error (#1169) [sync] #714

Merged
merged 1 commit into from Mar 13, 2024
Merged

NO-ISSUE: Semver lastedge error (#1169) [sync] #714

merged 1 commit into from Mar 13, 2024

Conversation

grokspawn
Copy link
Contributor

  • when the last edge in a bundle set is +Y the existing code does not clear the skips list and crosses Y thresholds counter to design intent missing proper last-max-z detection for replaces
    working at long last

  • re-add cumulative skips over y changes in an x stream so folks can always skip directly to channel head

Upstream-repository: operator-registry
Upstream-commit: 2096c4f5d0d2cb3ed31767d406afe10786565f01

@grokspawn
Semver lastedge error (#1169)
1913f58 
* when the last edge in a bundle set is +Y the existing code does not clear the skips list and crosses Y thresholds counter to design intent
missing proper last-max-z detection for replaces
working at long last

* re-add cumulative skips over y changes in an x stream so folks can always skip directly to channel head

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

---------

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Upstream-repository: operator-registry
Upstream-commit: 2096c4f5d0d2cb3ed31767d406afe10786565f01
@grokspawn grokspawn changed the title Semver lastedge error (#1169) NO-ISSUE: Semver lastedge error (#1169) [sync] Mar 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 11, 2024
@openshift-ci-robot
Copy link

@grokspawn: This pull request explicitly references no jira issue.

In response to this:

  • when the last edge in a bundle set is +Y the existing code does not clear the skips list and crosses Y thresholds counter to design intent missing proper last-max-z detection for replaces
    working at long last

  • re-add cumulative skips over y changes in an x stream so folks can always skip directly to channel head

Upstream-repository: operator-registry
Upstream-commit: 2096c4f5d0d2cb3ed31767d406afe10786565f01

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from anik120 and oceanc80 March 11, 2024 16:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
tmshort
tmshort approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort
Copy link
Contributor

tmshort commented Mar 11, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c84b6ad and 2 for PR HEAD 1913f58 in total

@grokspawn
Copy link
Contributor Author

/retest

2 similar comments
@grokspawn
Copy link
Contributor Author

/retest

@grokspawn
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

@grokspawn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-olm-flaky 1913f58 link false /test e2e-gcp-olm-flaky

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 613e0b1 into openshift:master Mar 13, 2024
12 of 13 checks passed
@grokspawn grokspawn deleted the sync-2024-03-11 branch March 13, 2024 01:49
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.16.0-202403130317.p0.g613e0b1.assembly.stream.el9 for distgit operator-lifecycle-manager.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmshort tmshort tmshort approved these changes

@anik120 anik120 Awaiting requested review from anik120

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@tmshort tmshort

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grokspawn @openshift-ci-robot @tmshort @openshift-bot