Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-30775: [4.14] bump grpc to 1.60.1, reconnect idle connections (#3147) #715

Merged
merged 2 commits into from Mar 15, 2024
Merged

OCPBUGS-30775: [4.14] bump grpc to 1.60.1, reconnect idle connections (#3147) #715

merged 2 commits into from Mar 15, 2024

Conversation

grokspawn
Copy link
Contributor

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e6d8fb022872af61bd34e80c185ff206d01dabcf

@grokspawn
Copy link
Contributor Author

/jira cherrypick OCPBUGS-30219

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@openshift-ci-robot
Copy link

@grokspawn: Jira Issue OCPBUGS-30219 has been cloned as Jira Issue OCPBUGS-30775. Will retitle bug to link to clone.
/retitle OCPBUGS-30775: [4.14] bump grpc to 1.60.1, reconnect idle connections (#3147)

In response to this:

/jira cherrypick OCPBUGS-30219

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [4.14] bump grpc to 1.60.1, reconnect idle connections (#3147) OCPBUGS-30775: [4.14] bump grpc to 1.60.1, reconnect idle connections (#3147) Mar 11, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 11, 2024
@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-30775, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30219 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e6d8fb022872af61bd34e80c185ff206d01dabcf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joelanford @grokspawn
containerdregistry: support per-repo credentials (#1165)
b805a09 
* containerdregistry: support per-repo credentials

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* containerdregistry: honor REGISTRY_AUTH_FILE or DOCKER_CONFIG, if set

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

---------

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 5e23ef594a41e6c8ce843d48b22715319c684dff
@grokspawn grokspawn force-pushed the otelgrpc-bump-4.14 branch 2 times, most recently from d26f98b to 7244a5f Compare March 12, 2024 21:10
@grokspawn
Copy link
Contributor Author

/retest

@grokspawn grokspawn force-pushed the otelgrpc-bump-4.14 branch 8 times, most recently from 444a25c to 56fbc9d Compare March 13, 2024 20:24
@joelanford @grokspawn
bump grpc to 1.60.1, reconnect idle connections (#3147)
5478698 
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e6d8fb022872af61bd34e80c185ff206d01dabcf
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelanford
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 14, 2024
@openshift-ci-robot
Copy link

@joelanford: This pull request references Jira Issue OCPBUGS-30775, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-30219 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-30219 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jfan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 14, 2024
@joelanford
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 14, 2024
everettraven
everettraven approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
tmshort
tmshort approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

KeenonLee
KeenonLee reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@KeenonLee KeenonLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dcfcfb3 into openshift:release-4.14 Mar 15, 2024
13 checks passed
@openshift-ci-robot
Copy link

@grokspawn: Jira Issue OCPBUGS-30775: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30775 has been moved to the MODIFIED state.

In response to this:

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e6d8fb022872af61bd34e80c185ff206d01dabcf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@grokspawn grokspawn deleted the otelgrpc-bump-4.14 branch March 15, 2024 14:20
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.14.0-202403191142.p0.gdcfcfb3.assembly.stream.el8 for distgit operator-lifecycle-manager.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeenonLee KeenonLee KeenonLee left review comments

@tmshort tmshort tmshort approved these changes

@everettraven everettraven everettraven approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@bandrade bandrade

@tmshort tmshort

@jianzhangbjz jianzhangbjz

@everettraven everettraven

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet