New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-32860: UPSTREAM: <carry>: bump go-jose #740
OCPBUGS-32860: UPSTREAM: <carry>: bump go-jose #740
Conversation
go-jose has a patched vulnerability -- https://nvd.nist.gov/vuln/detail/CVE-2024-28180 operator-registry has an indirect dependency on that package as part of its grpc health probe. however, the current version of the grpc dependency relies on a deprecated version of the package. this carry commit updates github.com/grpc-ecosystem/grpc-health-probe to 0.4.24 so that we can update the indirect dependency to use the non deprecated repository for go-jose, then updates go-jose to v3.0.3 where the vulnerability is patched. Resolves https://issues.redhat.com/browse/OCPBUGS-32860 Signed-off-by: kevinrizza <krizza@redhat.com>
@kevinrizza: This pull request references Jira Issue OCPBUGS-32860, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@kevinrizza: This pull request references Jira Issue OCPBUGS-32860, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jfan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
In the upstream version of this, we were updating docker and go-jose came along for the ride. It looks like this PR is trying to just bump go-jose without also bumping docker. Shouldn't it delete these lines though? |
@grokspawn actually, the upstream change that bumped go-jose to 3.0.1 was operator-framework/operator-registry#1197, which was a dependabot update for github.com/grpc-ecosystem/grpc-health-probe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, kevinrizza, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ah. That bumped to 3.0.1, right. But it was eventually bumped to 3.0.3 via #1239 and #1243. If we decouple the docker and go-jose updates, that's fine. |
@kevinrizza: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label backport-risk-assessed |
@bandrade any chance we can get this one labeled for merge? |
/label cherry-pick-approved |
50f148e
into
openshift:release-4.15
@kevinrizza: Jira Issue OCPBUGS-32860: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-32860 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build operator-registry-container-v4.15.0-202405070106.p0.g50f148e.assembly.stream.el9 for distgit operator-registry. |
[ART PR BUILD NOTIFIER] This PR has been included in build operator-lifecycle-manager-container-v4.15.0-202405070106.p0.g50f148e.assembly.stream.el9 for distgit operator-lifecycle-manager. |
Fix included in accepted release 4.15.0-0.nightly-2024-05-07-065351 |
/cherry-pick release-4.14 |
@kevinrizza: new pull request created: #743 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
go-jose has a patched vulnerability -- https://nvd.nist.gov/vuln/detail/CVE-2024-28180 operator-registry has an indirect dependency on that package as part of its grpc health probe. however, the current version of the grpc dependency relies on a deprecated version of the package. this carry commit updates github.com/grpc-ecosystem/grpc-health-probe to 0.4.24 so that we can update the indirect dependency to use the non deprecated repository for go-jose, then updates go-jose to v3.0.3 where the vulnerability is patched.
Resolves https://issues.redhat.com/browse/OCPBUGS-32860