Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-23403: [release-4.13] Address http2 vulnerability #58

Merged
merged 5 commits into from Nov 20, 2023
Merged

OCPBUGS-23403: [release-4.13] Address http2 vulnerability #58

merged 5 commits into from Nov 20, 2023

Conversation

awgreene
Copy link
Contributor

No description provided.

@awgreene
UPSTREAM: 754: Bump k8s dependencies
53fe88c 
Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@awgreene
UPSTREAM: 754: Disable HTTP/2 for Webhook Servers
b12456e 
Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@awgreene
UPSTREAM: 754: Bump kube-rbac-proxy to v0.15.0
b95bd3f 
Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@awgreene
UPSTREAM: 761: Reintroduce webhook version flag
fb8d57e 
Reintroduces the version flag to the webhook binary which was
accidentally removed in Pull Request #754.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@awgreene
UPSTREAM: <drop>: go mod vendor
b801448 
Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@awgreene
Copy link
Contributor Author

/jira cherry-pick OCPBUGS-23358

@openshift-ci openshift-ci bot requested review from ncdc and tmshort November 17, 2023 16:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2023
@awgreene
Copy link
Contributor Author

It seems that we don't need to generate downstream specific manifests as we did in the parent PR

@awgreene awgreene changed the title [release-4.13] Address http2 vulnerability OCPBUGS-23403: [release-4.13] Address http2 vulnerability Nov 17, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 17, 2023
@openshift-ci-robot
Copy link

@awgreene: This pull request references Jira Issue OCPBUGS-23403, which is invalid:

  • expected the bug to target either version "4.13." or "openshift-4.13.", but it targets "4.14.z" instead
  • expected dependent Jira Issue OCPBUGS-23358 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tmshort
Copy link
Contributor

tmshort commented Nov 17, 2023

One question, but otherwise...

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort
Copy link
Contributor

tmshort commented Nov 17, 2023

Updated OCPBUGS-23403 target version, but 23358 needs to get past ON_QA

@awgreene
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 20, 2023
@openshift-ci-robot
Copy link

@awgreene: This pull request references Jira Issue OCPBUGS-23403, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-23358 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-23358 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 20, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 1261b81 into openshift:release-4.13 Nov 20, 2023
6 checks passed
@openshift-ci-robot
Copy link

@awgreene: Jira Issue OCPBUGS-23403: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23403 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-olm-rukpak-container-v4.13.0-202311201431.p0.g1261b81.assembly.stream for distgit ose-olm-rukpak.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.13.0-0.nightly-2023-11-20-152406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmshort tmshort tmshort approved these changes

@ncdc ncdc Awaiting requested review from ncdc

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

Assignees

@tmshort tmshort

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@awgreene @openshift-ci-robot @tmshort @openshift-bot @openshift-merge-robot @ncdc