Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15]: OCPBUGS-30264: Bump Helm & K8s dependencies #79

Merged
merged 2 commits into from Mar 8, 2024
Merged

[release-4.15]: OCPBUGS-30264: Bump Helm & K8s dependencies #79

merged 2 commits into from Mar 8, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Mar 1, 2024 •
edited

Manual cherry pick.

There are two commits: one contains go mod vendor and another actual changes.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 1, 2024
@openshift-ci-robot
Copy link

@m1kola: This pull request references Jira Issue OCPBUGS-29504, which is invalid:

  • expected Jira Issue OCPBUGS-29504 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry pick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@m1kola m1kola force-pushed the helm-k8s-bump-4.15 branch 7 times, most recently from 0eb04a7 to 717f8a3 Compare March 5, 2024 11:13
@m1kola
UPSTREAM: <carry>: Bump Helm & K8s dependencies
e3118b8 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola marked this pull request as ready for review March 5, 2024 11:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2024
@openshift-ci openshift-ci bot requested review from grokspawn and tmshort March 5, 2024 11:56
@m1kola
UPSTREAM: <carry>: go mod vendor
20a75c2 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola
Copy link
Member Author

m1kola commented Mar 5, 2024

/cc @varshaprasad96

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 5, 2024

@m1kola: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevinrizza
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 5, 2024
@m1kola
Copy link
Member Author

m1kola commented Mar 5, 2024

Putting on hold until I sort out Jira tickets.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 5, 2024
Merged
@m1kola
Copy link
Member Author

m1kola commented Mar 5, 2024

/retitle [release-4.15]: OCPBUGS-30264: Bump Helm & K8s dependencies

@openshift-ci openshift-ci bot changed the title [release-4.15]: OCPBUGS-29504: Bump Helm & K8s dependencies [release-4.15]: OCPBUGS-30264: Bump Helm & K8s dependencies Mar 5, 2024
@openshift-ci-robot
Copy link

@m1kola: This pull request references Jira Issue OCPBUGS-30264, which is invalid:

  • expected Jira Issue OCPBUGS-30264 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry pick.

There are two commits: one contains go mod vendor and another actual changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@m1kola
Copy link
Member Author

m1kola commented Mar 5, 2024

/jira refresh

@openshift-ci-robot
Copy link

@m1kola: This pull request references Jira Issue OCPBUGS-30264, which is invalid:

  • expected Jira Issue OCPBUGS-30264 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

varshaprasad96
varshaprasad96 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @m1kola :))

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@m1kola
Copy link
Member Author

m1kola commented Mar 6, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 6, 2024
@openshift-ci-robot
Copy link

@m1kola: This pull request references Jira Issue OCPBUGS-30264, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29504 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29504 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from kuiwang02 March 6, 2024 09:14
@m1kola
Copy link
Member Author

m1kola commented Mar 6, 2024

/unhold

Jira tickets are now in good order.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@tmshort
Copy link
Contributor

tmshort commented Mar 7, 2024

/approve

@kuiwang02
Copy link

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Mar 8, 2024
@openshift-ci-robot
Copy link

@m1kola: This pull request references Jira Issue OCPBUGS-30264, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29504 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29504 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

Manual cherry pick.

There are two commits: one contains go mod vendor and another actual changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kevinrizza
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, m1kola, tmshort, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5b09cd4 into openshift:release-4.15 Mar 8, 2024
9 checks passed
@openshift-ci-robot
Copy link

@m1kola: Jira Issue OCPBUGS-30264: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30264 has been moved to the MODIFIED state.

In response to this:

Manual cherry pick.

There are two commits: one contains go mod vendor and another actual changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@m1kola m1kola deleted the helm-k8s-bump-4.15 branch March 8, 2024 13:02
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-olm-rukpak-container-v4.15.0-202403081338.p0.g5b09cd4.assembly.stream.el8 for distgit ose-olm-rukpak.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@grokspawn grokspawn Awaiting requested review from grokspawn

@tmshort tmshort Awaiting requested review from tmshort

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

Assignees

@bandrade bandrade

@jianzhangbjz jianzhangbjz

@varshaprasad96 varshaprasad96

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@m1kola @openshift-ci-robot @kevinrizza @tmshort @kuiwang02 @openshift-bot @varshaprasad96 @bandrade @jianzhangbjz @Xia-Zhao-rh