Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.10] treat all non-kubernetes containers as journal.system logs #1359

Conversation

richm
Copy link
Contributor

@richm richm commented Sep 24, 2018

(cherry picked from commit dc1128f)

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 24, 2018
@richm richm changed the title treat all non-kubernetes containers as journal.system logs [release-3.10] treat all non-kubernetes containers as journal.system logs Sep 24, 2018
@richm richm added kind/bug Categorizes issue or PR as related to a bug. component/elasticsearch component/fluentd release/3.10 this PR is targeted for OCP 3.10 labels Sep 24, 2018
@richm
Copy link
Contributor Author

richm commented Sep 24, 2018

/lgtm

@openshift-ci-robot
Copy link

@richm: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2018
@openshift-merge-robot openshift-merge-robot merged commit b438524 into openshift:release-3.10 Sep 25, 2018
@richm richm deleted the release-3.10-handle-non-k8s-containers branch September 25, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/elasticsearch component/fluentd kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release/3.10 this PR is targeted for OCP 3.10 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants